Issue 235893014: Document.dir should reflect the 'dir' attribute of the root html element

Issue 235893014: Document.dir should reflect the 'dir' attribute of the root html element (Closed)

Created:
6 years, 8 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
tkent, arv (Not doing code reviews)

CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Document.dir should reflect the 'dir' attribute of the root html element Document.dir should reflect the 'dir' attribute of the root html element as per the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#dom-document-dir Previously, Chromium was reflecting the the 'dir' attribute of the body element. The new behavior is consistent with Firefox 28 and IE11. R=arv@chromium.org,tkent@chromium.org BUG=363107 TEST=fast/dom/document-dir-property.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171734

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -26 lines)			Patch
M	LayoutTests/fast/dom/document-dir-property.html	View	2 chunks	+16 lines, -11 lines	1 comment	Download
M	LayoutTests/fast/dom/document-dir-property-expected.txt	View	1 chunk	+14 lines, -9 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Inactive

https://codereview.chromium.org/235893014/diff/1/LayoutTests/fast/dom/document-dir-property.html File LayoutTests/fast/dom/document-dir-property.html (right): https://codereview.chromium.org/235893014/diff/1/LayoutTests/fast/dom/document-dir-property.html#newcode13 LayoutTests/fast/dom/document-dir-property.html:13: description("document.dir should reflect the 'dir' content attribute of the ...

6 years, 8 months ago (2014-04-15 16:35:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/235893014/1

6 years, 8 months ago (2014-04-16 01:33:06 UTC) #4

Message was sent while issue was closed.

Change committed as 171734

Expand Messages | Collapse Messages