Issue 235893005: Fix initial FPSCR state in ARM simulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235893005: Fix initial FPSCR state in ARM simulator (Closed)

Created:
6 years, 8 months ago by oetuaho-nv

Modified:
6 years, 8 months ago

Reviewers:
jbramley, rmcilroy

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

Fix initial FPSCR state in ARM simulator Rounding mode should be round-to-nearest by default, and NaN mode bit should be 0, like in a real ARM system. BUG=3253 LOG=N R=rmcilroy@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20725

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/arm/simulator-arm.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

oetuaho-nv

Spun off from https://codereview.chromium.org/230473005/

6 years, 8 months ago (2014-04-14 12:00:00 UTC) #1

rmcilroy

On 2014/04/14 12:00:00, oetuaho-nv wrote: > Spun off from https://codereview.chromium.org/230473005/ lgtm. Thanks.

6 years, 8 months ago (2014-04-14 12:49:09 UTC) #2

rmcilroy

6 years, 8 months ago (2014-04-14 12:50:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20725 (presubmit successful).