Source/modules/websockets/WebSocketHandshake.cpp - Issue 235893003: Remove use of WebCrypto digestSynchronous in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/WebSocketHandshake.cpp

Issue 235893003: Remove use of WebCrypto digestSynchronous in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/websockets/WebSocketHandshake.cpp

diff --git a/Source/modules/websockets/WebSocketHandshake.cpp b/Source/modules/websockets/WebSocketHandshake.cpp

index 8def260211d99ec01d31d12fbaff82a571d8c784..70ba42c5133e91133a9b1d5a4180a8c732d5773c 100644

--- a/Source/modules/websockets/WebSocketHandshake.cpp

+++ b/Source/modules/websockets/WebSocketHandshake.cpp

@@ -126,7 +126,8 @@ String WebSocketHandshake::getExpectedWebSocketAccept(const String& secWebSocket

digestable.append(webSocketKeyGUID, strlen(webSocketKeyGUID));

CString digestableCString = digestable.toString().utf8();

DigestValue digest;

- computeDigest(HashAlgorithmSha1, digestableCString.data(), digestableCString.length(), digest);

+ bool digestSuccess = computeDigest(HashAlgorithmSha1, digestableCString.data(), digestableCString.length(), digest);

+ ASSERT_WITH_SECURITY_IMPLICATION(digestSuccess);

abarth-chromium 2014/04/11 23:26:20 Why not just RELEASE_ASSERT ?

return base64Encode(reinterpret_cast<const char*>(digest.data()), sha1HashSize);

}

« no previous file with comments | « Source/core/frame/csp/ContentSecurityPolicy.cpp ('k') | Source/platform/Crypto.h » ('j') | no next file with comments »