Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2358923003: [wasm] Bound the table size by Smi::kMaxValue. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Bound the table size by Smi::kMaxValue. BUG=chromium:649283 R=titzer@chromium.org TEST=mjsunit/wasm/table Committed: https://crrev.com/10d7ad9d9469f7a862d89c6f561b59053b70288e Cr-Commit-Position: refs/heads/master@{#39711}

Patch Set 1 #

Patch Set 2 : Bound the table size by 2^26 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/wasm/wasm-js.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/table.js View 1 2 chunks +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
ahaas
4 years, 3 months ago (2016-09-22 13:49:49 UTC) #1
ahaas
On 2016/09/22 at 13:49:49, ahaas wrote: > I changed the upper bound of the table ...
4 years, 3 months ago (2016-09-22 14:30:22 UTC) #8
titzer
On 2016/09/22 14:30:22, ahaas wrote: > On 2016/09/22 at 13:49:49, ahaas wrote: > > > ...
4 years, 2 months ago (2016-09-26 09:50:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358923003/20001
4 years, 2 months ago (2016-09-26 09:52:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 10:15:09 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 10:15:24 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10d7ad9d9469f7a862d89c6f561b59053b70288e
Cr-Commit-Position: refs/heads/master@{#39711}

Powered by Google App Engine
This is Rietveld 408576698