views: remove PlatformStyle::CreateLabelButtonBorder

views: remove PlatformStyle::CreateLabelButtonBorder

This function was doing the wrong thing on Mac, so it has been removed and
the default implementation simply inlined into LabelButton.

BUG=649367
Committed: https://crrev.com/8b9fd5ef2fb2722e3d6d60531622715b186492c0
Cr-Commit-Position: refs/heads/master@{#421188}

[Elly Fong-Jones, 2016-09-22 18:05:50]

Description was changed from

==========
views: remove PlatformStyle::CreateLabelButtonBorder

This function was doing the wrong thing on Mac, so it has been removed and
the default implementation simply inlined into LabelButton.

BUG=649367
==========

to

==========
views: remove PlatformStyle::CreateLabelButtonBorder

This function was doing the wrong thing on Mac, so it has been removed and
the default implementation simply inlined into LabelButton.

BUG=649367
==========

[Elly Fong-Jones, 2016-09-22 18:05:51]

ellyjones@chromium.org changed reviewers:
+ estade@chromium.org, sky@chromium.org

[Elly Fong-Jones, 2016-09-22 18:05:57]

estade, sky: ptal? :)

[Evan Stade, 2016-09-22 22:21:11]

https://codereview.chromium.org/2358913006/diff/1/ui/views/controls/button/la...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/2358913006/diff/1/ui/views/controls/button/la...
ui/views/controls/button/label_button.cc:392: std::unique_ptr<LabelButtonBorder>
LabelButton::CreateDefaultBorder() const {
harmony should allow us to get rid of this completely (I think). As an
intermediate step this patch lgtm

[sky, 2016-09-23 15:47:39]

LGTM

https://codereview.chromium.org/2358913006/diff/1/ui/views/controls/button/la...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/2358913006/diff/1/ui/views/controls/button/la...
ui/views/controls/button/label_button.cc:397: std::unique_ptr<LabelButtonBorder>
border(new views::LabelButtonBorder());
MakeUnique?

https://codereview.chromium.org/2358913006/diff/1/ui/views/style/platform_sty...
File ui/views/style/platform_style.h (left):

https://codereview.chromium.org/2358913006/diff/1/ui/views/style/platform_sty...
ui/views/style/platform_style.h:75: static std::unique_ptr<LabelButtonBorder>
CreateLabelButtonBorder(
Is there any includes/forward declarations no longer necessary please remove
them.

[Elly Fong-Jones, 2016-09-23 17:28:38]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-09-23 17:28:39]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2358913006/#ps20001
(title: "MakeUnique and dead includes")

[commit-bot: I haz the power, 2016-09-23 17:29:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 17:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 17:40:14]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Elly Fong-Jones, 2016-09-23 18:07:03]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-09-23 18:07:04]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2358913006/#ps40001
(title: "put that include back")

[commit-bot: I haz the power, 2016-09-23 18:07:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 19:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 19:28:59]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Elly Fong-Jones, 2016-09-26 17:20:29]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-09-26 17:20:29]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2358913006/#ps60001
(title: "remove DialogButtonBorderMac too")

[commit-bot: I haz the power, 2016-09-26 17:20:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 19:09:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 19:09:06]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Elly Fong-Jones, 2016-09-27 12:16:28]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-27 12:16:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 13:22:17]

Description was changed from

==========
views: remove PlatformStyle::CreateLabelButtonBorder

This function was doing the wrong thing on Mac, so it has been removed and
the default implementation simply inlined into LabelButton.

BUG=649367
==========

to

==========
views: remove PlatformStyle::CreateLabelButtonBorder

This function was doing the wrong thing on Mac, so it has been removed and
the default implementation simply inlined into LabelButton.

BUG=649367
==========

[commit-bot: I haz the power, 2016-09-27 13:22:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-27 13:24:03]

Description was changed from

==========
views: remove PlatformStyle::CreateLabelButtonBorder

This function was doing the wrong thing on Mac, so it has been removed and
the default implementation simply inlined into LabelButton.

BUG=649367
==========

to

==========
views: remove PlatformStyle::CreateLabelButtonBorder

This function was doing the wrong thing on Mac, so it has been removed and
the default implementation simply inlined into LabelButton.

BUG=649367

Committed: https://crrev.com/8b9fd5ef2fb2722e3d6d60531622715b186492c0
Cr-Commit-Position: refs/heads/master@{#421188}
==========

[commit-bot: I haz the power, 2016-09-27 13:24:04]

Patchset 4 (id:??) landed as
https://crrev.com/8b9fd5ef2fb2722e3d6d60531622715b186492c0
Cr-Commit-Position: refs/heads/master@{#421188}