Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2358913004: Change image document zooming logic. (Closed)

Created:
4 years, 3 months ago by Bret
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Change image document zooming logic. The current zoom logic in image documents interacts badly with use-zoom-for-dsf, in addition to having some weird behavior already. This patch changes three things: 1. When loading a large image when page zoom was not 100% the image would start at a strange scaling factor until it was clicked. This is fixed. 2. When page zoom is at 100% a large image will always scale to fit the window regardless of the device scale factor. Previously with use-zoom-for-dsf on it would scale too large for the window. 3. When an image that fits in the window is zoomed in until it doesn't it is no longer clickable. Previously it would start acting like a large image, which was strange. Also added a test suite for ImageDocument. BUG=324086, 644059 Review-Url: https://codereview.chromium.org/2319863006 Cr-Commit-Position: refs/heads/master@{#419867} (cherry picked from commit f5ff44ae79899d114b4bbf5abdd6e960f856c0d9) Committed: https://chromium.googlesource.com/chromium/src/+/feb3b0ed99499d6232d2d0d2ce5129c95fa51db0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -41 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.h View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 7 chunks +26 lines, -32 lines 0 comments Download
A third_party/WebKit/Source/core/html/ImageDocumentTest.cpp View 1 chunk +195 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Bret
4 years, 3 months ago (2016-09-21 23:23:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
feb3b0ed99499d6232d2d0d2ce5129c95fa51db0.

Powered by Google App Engine
This is Rietveld 408576698