Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: test/mjsunit/array-push-non-smi-value.js

Issue 23589002: MIPS: Fix return-value from Array.push stub when pushing non-SMI value (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: "Rewind" testcase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/array-push-non-smi-value.js
diff --git a/test/mjsunit/compiler/minus-zero.js b/test/mjsunit/array-push-non-smi-value.js
similarity index 90%
copy from test/mjsunit/compiler/minus-zero.js
copy to test/mjsunit/array-push-non-smi-value.js
index 6efceb54e36834c217732a7974f0c5d2a2cca132..af4501feff1a401cdea64e51d999823e7fa418c5 100644
--- a/test/mjsunit/compiler/minus-zero.js
+++ b/test/mjsunit/array-push-non-smi-value.js
@@ -27,11 +27,12 @@
// Flags: --allow-natives-syntax
Jakob Kummerow 2013/08/27 16:52:53 Now you don't need this anymore.
-function add(x, y) {
- return x + y;
+// Check pushes of non-SMI values.
+var a = [];
+function func() {
+ return a.push(0x40000000) > 60;
}
-assertEquals(0, add(0, 0));
-assertEquals(0, add(0, 0));
-%OptimizeFunctionOnNextCall(add);
-assertEquals(-0, add(-0, -0));
+assertFalse(func());
+assertFalse(func());
+assertFalse(func());
« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698