MIPS: Fix return-value from Array.push stub when pushing non-SMI value

test/mjsunit/array-push-non-smi-value.js

Index: test/mjsunit/array-push-non-smi-value.js
diff --git a/test/mjsunit/compare-nil.js b/test/mjsunit/array-push-non-smi-value.js
similarity index 91%
copy from test/mjsunit/compare-nil.js
copy to test/mjsunit/array-push-non-smi-value.js
index 0895a31fb80cbe697b678eaa1005926d7d65829f..4fe6e859d4612c02f5c6885dcf8d42cdb06670c9 100644
--- a/test/mjsunit/compare-nil.js
+++ b/test/mjsunit/array-push-non-smi-value.js
@@ -27,10 +27,11 @@
 
 // Flags: --allow-natives-syntax
 
-function test(v) {
-  return (v == null);
-}
-assertFalse(test(true));
-assertFalse(test(true));
-assertTrue(test(null));
-assertTrue(test(null));
+// Check pushes of non-SMI values.
+(function() {

[Jakob Kummerow, 2013/08/27 13:58:36]

Why the outer closure?

[fs, 2013/08/27 16:16:13]

Why indeed. Dropped.

+  var a = [];
+
+  %OptimizeFunctionOnNextCall(a.push);

[Jakob Kummerow, 2013/08/27 13:58:36]

The patch only affects the stub. Why optimize the function?

[fs, 2013/08/27 16:16:13]

I rolled back the TC a few steps (I suspect I tried to minimize it a bit too
aggressively...) I hope it makes more sense in that form. (I'm can't claim to be
entirely familiar with all details around stubs, so guidance towards a better TC
would be most appreciated.)

+
+  assertEquals(1, a.push(0x40000000));
+})();