Deprecate chrome.contentSettings.{fullscreen,mouselock} extension API.

chrome/test/data/extensions/api_test/content_settings/standard/test.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Content settings API test
 // Run with browser_tests --gtest_filter=ExtensionApiTest.ContentSettings
 
 var cs = chrome.contentSettings;
 var default_content_settings = {
   "cookies": "session_only",
@@ skipping 12 matching lines @@
 };
 
 var settings = {
   "cookies": "block",
   "images": "allow",
   "javascript": "block",
   "plugins": "detect_important_content",
   "popups": "allow",
   "location": "block",
   "notifications": "block",
-  "fullscreen": "allow",
-  "mouselock": "block",
+  "fullscreen": "block",  // Should be ignored.
+  "mouselock": "block",  // Should be ignored.
   "microphone": "block",
   "camera": "block",
   "unsandboxedPlugins": "block",
   "automaticDownloads": "block"
 };
 
+// If omitted, expected to be the same as |settings|.
+var expectations = {

[Devlin, 2016/09/26 20:30:37]

I would add a bit more context here, and rename this to something like
deprecatedSettingsExpectations.

[Matt Giuca, 2016/09/27 01:18:33]

Done.

+  // Due to deprecation, these should be "allow", regardless of the setting.
+  "fullscreen": "allow",

[Devlin, 2016/09/26 20:30:37]

prefer single quotes in js

[Matt Giuca, 2016/09/27 01:18:33]

I think it's appropriate to stay consistent with the style of the above two
blocks which use double quotes.

+  "mouselock": "allow"
+};
+
 Object.prototype.forEach = function(f) {
   var k;
   for (k in this) {
     if (this.hasOwnProperty(k))
       f(k, this[k]);
   }
 };
 
 function expect(expected, message) {
   return chrome.test.callbackPass(function(value) {
@@ skipping 22 matching lines @@
     settings.forEach(function(type, setting) {
       cs[type].set({
         'primaryPattern': 'http://*.google.com/*',
         'secondaryPattern': 'http://*.google.com/*',
         'setting': setting
       }, chrome.test.callbackPass());
     });
   },
   function getContentSettings() {
     settings.forEach(function(type, setting) {
+      setting = expectations[type] || setting;
       var message = "Setting for " + type + " should be " + setting;
       cs[type].get({
         'primaryUrl': 'http://www.google.com',
         'secondaryUrl': 'http://www.google.com'
       }, expect({'setting':setting}, message));
     });
   },
   function invalidSettings() {
     cs.cookies.get({
       'primaryUrl': 'moo'
     }, chrome.test.callbackFail("The URL \"moo\" is invalid."));
     cs.plugins.set({
       'primaryPattern': 'http://example.com/*',
       'secondaryPattern': 'http://example.com/path',
       'setting': 'block'
     }, chrome.test.callbackFail("Specific paths are not allowed."));
     cs.javascript.set({
       'primaryPattern': 'http://example.com/*',
       'secondaryPattern': 'file:///home/hansmoleman/*',
       'setting': 'allow'
     }, chrome.test.callbackFail(
         "Path wildcards in file URL patterns are not allowed."));
   }
 ]);