Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2358833003: [ash-md] Corrects initial positioning of the overview headers (Closed)

Created:
4 years, 3 months ago by varkha
Modified:
4 years, 3 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Corrects initial positioning of the overview headers This regression was introduced when order of initialization was changed in https://codereview.chromium.org/2336673002/ . This CL restores the order. BUG=648520 Committed: https://crrev.com/a241953aa9d0ecd5375771e634f8638e004a9961 Cr-Commit-Position: refs/heads/master@{#420346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/common/wm/overview/window_selector_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
varkha
tdanderson@, can you please take a look at this? This is effectively reverting an incidental ...
4 years, 3 months ago (2016-09-22 01:48:54 UTC) #4
tdanderson
lgtm
4 years, 3 months ago (2016-09-22 14:33:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358833003/1
4 years, 3 months ago (2016-09-22 15:11:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 15:16:14 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 15:19:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a241953aa9d0ecd5375771e634f8638e004a9961
Cr-Commit-Position: refs/heads/master@{#420346}

Powered by Google App Engine
This is Rietveld 408576698