Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 235883010: Revert 262846, as the revert has now been merged to M35. (Closed)

Created:
6 years, 8 months ago by mmenke
Modified:
6 years, 8 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 262846, as the revert has now been merged to M35. Still need to fix the underlying tracking issue before M36 branch. > Revert 255617, due to it not tracking use of the link doctor page properly. > > Not reverting the string changes, because the new strings work with the old > file, and we've passed string freeze. > > > Switch to using the new Link Doctor API. > > > > The new API allows Link Doctor results to be integrated into Chrome's > > own error pages. > > BUG=64832, 359131 > TBR=mmenke@chromium.org > > Originally Landed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255617 > > Review URL: https://codereview.chromium.org/228803002 TBR=mmenke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1394 lines, -642 lines) Patch
M trunk/src/chrome/browser/chromeos/offline/offline_load_page.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/errorpage_browsertest.cc View 18 chunks +212 lines, -68 lines 0 comments Download
M trunk/src/chrome/browser/google/google_util.h View 2 chunks +9 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/google/google_util.cc View 3 chunks +43 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/net/dns_probe_browsertest.cc View 26 chunks +144 lines, -121 lines 0 comments Download
M trunk/src/chrome/browser/net/url_request_mock_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/prefs/browser_prefs.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D trunk/src/chrome/browser/ui/alternate_error_tab_observer.h View 1 chunk +0 lines, -61 lines 0 comments Download
D trunk/src/chrome/browser/ui/alternate_error_tab_observer.cc View 1 chunk +0 lines, -101 lines 0 comments Download
A + trunk/src/chrome/browser/ui/navigation_correction_tab_observer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/navigation_correction_tab_observer.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/ui/tab_helpers.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/localized_error.h View 3 chunks +24 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/localized_error.cc View 8 chunks +48 lines, -16 lines 0 comments Download
M trunk/src/chrome/common/render_messages.h View 1 chunk +8 lines, -3 lines 0 comments Download
M trunk/src/chrome/renderer/net/net_error_helper.h View 2 chunks +18 lines, -9 lines 0 comments Download
M trunk/src/chrome/renderer/net/net_error_helper.cc View 9 chunks +56 lines, -24 lines 0 comments Download
M trunk/src/chrome/renderer/net/net_error_helper_core.h View 6 chunks +30 lines, -11 lines 0 comments Download
M trunk/src/chrome/renderer/net/net_error_helper_core.cc View 11 chunks +263 lines, -83 lines 0 comments Download
M trunk/src/chrome/renderer/net/net_error_helper_core_unittest.cc View 32 chunks +448 lines, -95 lines 0 comments Download
M trunk/src/chrome/renderer/resources/neterror.css View 8 chunks +58 lines, -11 lines 0 comments Download
M trunk/src/chrome/renderer/resources/neterror.html View 2 chunks +20 lines, -5 lines 0 comments Download
M trunk/src/chrome/renderer/resources/neterror.js View 1 chunk +7 lines, -0 lines 0 comments Download
D trunk/src/chrome/test/data/mock-link-doctor.html View 1 chunk +0 lines, -4 lines 0 comments Download
A + trunk/src/chrome/test/data/mock-link-doctor.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/test/data/mock-link-doctor.html.mock-http-headers View 1 chunk +0 lines, -2 lines 0 comments Download
A + trunk/src/chrome/test/data/mock-link-doctor.json.mock-http-headers View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmenke
6 years, 8 months ago (2014-04-15 18:59:21 UTC) #1
mmenke
6 years, 8 months ago (2014-04-15 19:00:01 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r263956.

Powered by Google App Engine
This is Rietveld 408576698