Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 235883002: IndexedDB: Make sure indexing completes if object store is deleted (Closed)

Created:
6 years, 8 months ago by jsbell
Modified:
6 years, 8 months ago
Reviewers:
alecflett, cmumford
CC:
blink-reviews, dgrogan, jsbell+idb_chromium.org, alecflett, ericu+idb_chromium.org, cmumford
Visibility:
Public.

Description

IndexedDB: Make sure indexing completes if object store is deleted Unhandled case found via W3c web-platform-tests. If an indexing operation is kicked off then the object store is deleted, an ASSERT was hit since the cursor is invalid. Check (via the cursor) that the store has not been deleted; if it has, stop indexing. BUG=362711 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
A LayoutTests/storage/indexeddb/createIndex-deleteObjectStore.htm View 1 chunk +26 lines, -0 lines 0 comments Download
A + LayoutTests/storage/indexeddb/createIndex-deleteObjectStore-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBCursor.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
cmumford@, alecflett@ - please take a look?
6 years, 8 months ago (2014-04-11 20:49:05 UTC) #1
cmumford
lgtm
6 years, 8 months ago (2014-04-11 20:55:45 UTC) #2
alecflett
lgtm
6 years, 8 months ago (2014-04-11 21:39:46 UTC) #3
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 8 months ago (2014-04-11 21:48:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/235883002/1
6 years, 8 months ago (2014-04-11 21:48:09 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 22:56:43 UTC) #6
Message was sent while issue was closed.
Change committed as 171377

Powered by Google App Engine
This is Rietveld 408576698