[css-grid] Remove redundant setNeedsLayout() call

[css-grid] Remove redundant setNeedsLayout() call

This extra call inside dirtyGrid() method was added as part of
crrev.com/887633002 as part of a fix for a crash. By that time the crash was
fixed but perhaps the underlying cause was not the lack of this extra
setNeedsLayout().

I've verified that the assertion is no longer triggered (by adding it back
as it was removed) and that the original test case that was crashing works
fine. This was double checked in an ASAN Debug build after running the test
for more than 10 minutes.

This removal will allow us to call dirtyGrid() even during intrinsic size
computation once all the attributes with cached data become mutable.

Committed: https://crrev.com/c113591d7ee0f0e03ad67b494b3ae4bb87de5911
Cr-Commit-Position: refs/heads/master@{#420303}

[svillar, 2016-09-21 14:07:47]

svillar@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, rego@igalia.com

[leca6121, 2016-09-21 14:11:05]

On 2016/09/21 14:07:47, svillar wrote:
Thaongoc

[svillar, 2016-09-21 14:23:54]

Description was changed from

==========
[css-grid] Remove redundant setNeedsLayout() call

This extra call inside dirtyGrid() method was added in crrev.com/189685 as
part of a fix for a crash. By that time the crash was fixed but perhaps the
underlying cause was not the lack of this extra setNeedsLayout().

I've verified that the assertion is no longer triggered (by adding it back
as it was removed) and that the original test case that was crashing works
fine. This was double checked in an ASAN Debug build after running the test
for more than 10 minutes.

This removal will allow us to call dirtyGrid() even during intrinsic size
computation once all the attributes with cached data become mutable.
==========

to

==========
[css-grid] Remove redundant setNeedsLayout() call

This extra call inside dirtyGrid() method was added as part of 
crrev.com/887633002 as part of a fix for a crash. By that time the crash was 
fixed but perhaps the underlying cause was not the lack of this extra 
setNeedsLayout().

I've verified that the assertion is no longer triggered (by adding it back
as it was removed) and that the original test case that was crashing works
fine. This was double checked in an ASAN Debug build after running the test
for more than 10 minutes.

This removal will allow us to call dirtyGrid() even during intrinsic size
computation once all the attributes with cached data become mutable.
==========

[svillar, 2016-09-21 15:16:16]

svillar@igalia.com changed reviewers:
+ eae@chromium.org
- leca6121@gmail.com

[cbiesinger, 2016-09-21 16:38:45]

lgtm

[svillar, 2016-09-22 07:57:42]

The CQ bit was checked by svillar@igalia.com

[svillar, 2016-09-22 07:57:42]

The CQ bit was unchecked by svillar@igalia.com

[svillar, 2016-09-22 10:13:45]

The CQ bit was checked by svillar@igalia.com

[commit-bot: I haz the power, 2016-09-22 10:14:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 11:30:24]

Description was changed from

==========
[css-grid] Remove redundant setNeedsLayout() call

This extra call inside dirtyGrid() method was added as part of 
crrev.com/887633002 as part of a fix for a crash. By that time the crash was 
fixed but perhaps the underlying cause was not the lack of this extra 
setNeedsLayout().

I've verified that the assertion is no longer triggered (by adding it back
as it was removed) and that the original test case that was crashing works
fine. This was double checked in an ASAN Debug build after running the test
for more than 10 minutes.

This removal will allow us to call dirtyGrid() even during intrinsic size
computation once all the attributes with cached data become mutable.
==========

to

==========
[css-grid] Remove redundant setNeedsLayout() call

This extra call inside dirtyGrid() method was added as part of 
crrev.com/887633002 as part of a fix for a crash. By that time the crash was 
fixed but perhaps the underlying cause was not the lack of this extra 
setNeedsLayout().

I've verified that the assertion is no longer triggered (by adding it back
as it was removed) and that the original test case that was crashing works
fine. This was double checked in an ASAN Debug build after running the test
for more than 10 minutes.

This removal will allow us to call dirtyGrid() even during intrinsic size
computation once all the attributes with cached data become mutable.
==========

[commit-bot: I haz the power, 2016-09-22 11:30:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-22 11:33:24]

Description was changed from

==========
[css-grid] Remove redundant setNeedsLayout() call

This extra call inside dirtyGrid() method was added as part of 
crrev.com/887633002 as part of a fix for a crash. By that time the crash was 
fixed but perhaps the underlying cause was not the lack of this extra 
setNeedsLayout().

I've verified that the assertion is no longer triggered (by adding it back
as it was removed) and that the original test case that was crashing works
fine. This was double checked in an ASAN Debug build after running the test
for more than 10 minutes.

This removal will allow us to call dirtyGrid() even during intrinsic size
computation once all the attributes with cached data become mutable.
==========

to

==========
[css-grid] Remove redundant setNeedsLayout() call

This extra call inside dirtyGrid() method was added as part of
crrev.com/887633002 as part of a fix for a crash. By that time the crash was
fixed but perhaps the underlying cause was not the lack of this extra
setNeedsLayout().

I've verified that the assertion is no longer triggered (by adding it back
as it was removed) and that the original test case that was crashing works
fine. This was double checked in an ASAN Debug build after running the test
for more than 10 minutes.

This removal will allow us to call dirtyGrid() even during intrinsic size
computation once all the attributes with cached data become mutable.

Committed: https://crrev.com/c113591d7ee0f0e03ad67b494b3ae4bb87de5911
Cr-Commit-Position: refs/heads/master@{#420303}
==========

[commit-bot: I haz the power, 2016-09-22 11:33:25]

Patchset 1 (id:??) landed as
https://crrev.com/c113591d7ee0f0e03ad67b494b3ae4bb87de5911
Cr-Commit-Position: refs/heads/master@{#420303}