Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2358803006:
Prune some CreateVisiblePositionDeprecated calls from EditingUtilities (Closed)
|
Created:
4 years, 3 months ago by Xiaocheng Modified:
4 years, 2 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrune some CreateVisiblePositionDeprecated calls from EditingUtilities
This patch prunes CreateVisiblePositionDeprecated from the following functions
in EditingUtilities because they are already called with clean layout:
- firstEditableVisiblePositionAfterPositionInRoot (both versions)
- lastEditableVisiblePositionAfterPositionInRoot (both versions)
- enclosingEmptyListItem
- visiblePositionForIndex
BUG=647219
Committed: https://crrev.com/80505b6a662126b962b8893046d0e68e5893c37f
Cr-Commit-Position: refs/heads/master@{#421062}
Patch Set 1 #Patch Set 2 : Include two more functions #Patch Set 3 : Mark needsLayoutTreeUpdateAlgorithm static #Patch Set 4 : Revision 201609261145 #
Messages
Total messages: 31 (24 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Prune some CreateVisiblePositionDeprecated calls from EditingUtilities BUG= ========== to ========== Prune some CreateVisiblePositionDeprecated calls from EditingUtilities This patch prunes CreateVisiblePositionDeprecated from the following functions in EditingUtilities because they are already called with clean layout: - firstEditableVisiblePositionAfterPositionInRoot (both versions) - lastEditableVisiblePositionAfterPositionInRoot (both versions) - enclosingEmptyListItem - visiblePositionForIndex BUG=647219 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
xiaochengh@chromium.org changed reviewers: + yosin@chromium.org
PTAL.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Prune some CreateVisiblePositionDeprecated calls from EditingUtilities This patch prunes CreateVisiblePositionDeprecated from the following functions in EditingUtilities because they are already called with clean layout: - firstEditableVisiblePositionAfterPositionInRoot (both versions) - lastEditableVisiblePositionAfterPositionInRoot (both versions) - enclosingEmptyListItem - visiblePositionForIndex BUG=647219 ========== to ========== Prune some CreateVisiblePositionDeprecated calls from EditingUtilities This patch prunes CreateVisiblePositionDeprecated from the following functions in EditingUtilities because they are already called with clean layout: - firstEditableVisiblePositionAfterPositionInRoot (both versions) - lastEditableVisiblePositionAfterPositionInRoot (both versions) - enclosingEmptyListItem - visiblePositionForIndex BUG=647219 Committed: https://crrev.com/80505b6a662126b962b8893046d0e68e5893c37f Cr-Commit-Position: refs/heads/master@{#421062} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/80505b6a662126b962b8893046d0e68e5893c37f Cr-Commit-Position: refs/heads/master@{#421062} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
