Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2358803005: Revert of Include addresses with the getdetailsforsavecard Payments RPC. (Closed)

Created:
4 years, 3 months ago by Garrett Casto
Modified:
4 years, 3 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, Jared Saul, zkoch1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include addresses with the getdetailsforsavecard Payments RPC. (patchset #3 id:60001 of https://codereview.chromium.org/2349033002/ ) Reason for revert: This change introduced static initializers. See https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/25932/steps/sizes/logs/stdio. See http://neugierig.org/software/chromium/notes/2011/08/static-initializers.html for more details on why this matters. Original issue's description: > Include addresses with the getdetailsforsavecard Payments RPC. > > These addresses will be used by Payments to determine the correct legal > documents to show the user and to verify that the addresses are valid > for their purposes (and thus won't fail on any subsequent save). > > Names and phone numbers are removed from the addresses before uploading > since they are not useful for these purposes. > > BUG=535784 > > Committed: https://crrev.com/da7eb69a380d53eec42cc4e620e55b78e5d6fa82 > Cr-Commit-Position: refs/heads/master@{#420409} TBR=estade@chromium.org,jdonnelly@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=535784 Committed: https://crrev.com/de9d174037a46f955c33513ac452e011c0520c27 Cr-Commit-Position: refs/heads/master@{#420440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -144 lines) Patch
M components/autofill/content/browser/payments/payments_client_unittest.cc View 5 chunks +1 line, -88 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/core/browser/payments/payments_client.h View 2 chunks +3 lines, -11 lines 0 comments Download
M components/autofill/core/browser/payments/payments_client.cc View 9 chunks +10 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Garrett Casto
Created Revert of Include addresses with the getdetailsforsavecard Payments RPC.
4 years, 3 months ago (2016-09-22 20:12:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358803005/1
4 years, 3 months ago (2016-09-22 20:13:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 20:15:28 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 20:18:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de9d174037a46f955c33513ac452e011c0520c27
Cr-Commit-Position: refs/heads/master@{#420440}

Powered by Google App Engine
This is Rietveld 408576698