Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3518)

Unified Diff: chrome/browser/policy/cloud/device_management_service.cc

Issue 23588009: Parse /etc/lsb-release only once on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/version_loader_unittest.cc ('k') | chrome/browser/ui/webui/help/help_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/cloud/device_management_service.cc
diff --git a/chrome/browser/policy/cloud/device_management_service.cc b/chrome/browser/policy/cloud/device_management_service.cc
index 4e13defe2e2d54d6353beb94bd09530c22d2cc5c..0e784d03685a742e2a6246eb79714926b4a73934 100644
--- a/chrome/browser/policy/cloud/device_management_service.cc
+++ b/chrome/browser/policy/cloud/device_management_service.cc
@@ -71,7 +71,6 @@ const int kPolicyNotFound = 902; // This error is not sent as HTTP status code.
#if defined(OS_CHROMEOS)
// Machine info keys.
const char kMachineInfoHWClass[] = "hardware_class";
-const char kMachineInfoBoard[] = "CHROMEOS_RELEASE_BOARD";
#endif
bool IsProxyError(const net::URLRequestStatus status) {
@@ -177,12 +176,9 @@ const std::string& GetPlatformString() {
chromeos::system::StatisticsProvider::GetInstance();
std::string hwclass;
- std::string board;
- if (!provider->GetMachineStatistic(kMachineInfoHWClass, &hwclass) ||
- !provider->GetMachineStatistic(kMachineInfoBoard, &board)) {
+ if (!provider->GetMachineStatistic(kMachineInfoHWClass, &hwclass))
LOG(ERROR) << "Failed to get machine information";
- }
- os_name += ",CrOS," + board;
+ os_name += ",CrOS," + base::SysInfo::GetLsbReleaseBoard();
os_hardware += "," + hwclass;
#endif
« no previous file with comments | « chrome/browser/chromeos/version_loader_unittest.cc ('k') | chrome/browser/ui/webui/help/help_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698