Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4369)

Unified Diff: chrome/browser/chromeos/system_logs/lsb_release_log_source.h

Issue 23588009: Parse /etc/lsb-release only once on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/system_logs/lsb_release_log_source.h
diff --git a/chrome/browser/chromeos/system_logs/lsb_release_log_source.h b/chrome/browser/chromeos/system_logs/lsb_release_log_source.h
index 146c7532b3f553b798ca7c0fddd3383fa1924c32..29a071a541501d95eed3b8c49cbc86844b24d1fe 100644
--- a/chrome/browser/chromeos/system_logs/lsb_release_log_source.h
+++ b/chrome/browser/chromeos/system_logs/lsb_release_log_source.h
@@ -17,20 +17,7 @@ class LsbReleaseLogSource : public SystemLogsSource {
// SystemLogsSource override.
virtual void Fetch(const SysLogsSourceCallback& callback) OVERRIDE;
- // For testing. Parses a key=value pairs from a string. There can be only one
- // pair per line and the value must confine to a single line.
- // Example:
- // foo = 1
- // bar = 2
- // Note: it automatically strips whitespaces from the front and back of values
- // and keys.
- static void ParseLSBRelease(const std::string& lsb_data,
- SystemLogsResponse* response);
-
private:
- // Gets the info from the /etc/lsb-release and parses it
- static void ReadLSBRelease(SystemLogsResponse* response);
-
DISALLOW_COPY_AND_ASSIGN(LsbReleaseLogSource);
};
« no previous file with comments | « chrome/browser/chromeos/system/statistics_provider.cc ('k') | chrome/browser/chromeos/system_logs/lsb_release_log_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698