Parse /etc/lsb-release only once on ChromeOS

chrome/browser/ui/webui/help/help_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/help/help_handler.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 107 matching lines @@
     return domain == g_browser_process->browser_policy_connector()->
         GetEnterpriseDomain();
   } else if (chromeos::UserManager::Get()->IsCurrentUserOwner()) {
     // On non managed machines we have local owner who is the only one to change
     // anything. Ensure that ReleaseChannelDelegated is false.
     return !value;
   }
   return false;
 }
 
-// Pointer to a |StringValue| holding the date of the build date to Chromium
-// OS. Because this value is obtained by reading a file, it is cached here to
-// prevent the need to read from the file system multiple times unnecessarily.
-Value* g_build_date_string = NULL;
-
 #endif  // defined(OS_CHROMEOS)
 
 }  // namespace
 
 HelpHandler::HelpHandler()
     : version_updater_(VersionUpdater::Create()),
       weak_factory_(this) {
 }
 
 HelpHandler::~HelpHandler() {
@@ skipping 193 matching lines @@
       base::Bind(&HelpHandler::OnOSVersion, base::Unretained(this)),
       &tracker_);
   loader_.GetFirmware(
       base::Bind(&HelpHandler::OnOSFirmware, base::Unretained(this)),
       &tracker_);
 
   web_ui()->CallJavascriptFunction(
       "help.HelpPage.updateEnableReleaseChannel",
       base::FundamentalValue(CanChangeChannel()));
 
-  if (g_build_date_string == NULL) {
-    // If |g_build_date_string| is |NULL|, the date has not yet been assigned.
-    // Get the date of the last lsb-release file modification.
-    base::FileUtilProxy::GetFileInfo(
-        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE).get(),
-        base::SysInfo::GetLsbReleaseFilePath(),
-        base::Bind(&HelpHandler::ProcessLsbFileInfo,
-                   weak_factory_.GetWeakPtr()));
-  } else {
-    web_ui()->CallJavascriptFunction("help.HelpPage.setBuildDate",
-                                     *g_build_date_string);
-  }
+  base::Time build_time = base::SysInfo::GetLsbReleaseTime();
+  string16 build_date = base::TimeFormatFriendlyDate(build_time);
+  web_ui()->CallJavascriptFunction("help.HelpPage.setBuildDate",
+                                   base::StringValue(build_date));
 #endif  // defined(OS_CHROMEOS)
 
   version_updater_->CheckForUpdate(
       base::Bind(&HelpHandler::SetUpdateStatus, base::Unretained(this))
 #if defined(OS_MACOSX)
       , base::Bind(&HelpHandler::SetPromotionState, base::Unretained(this))
 #endif
       );
 
 #if defined(OS_CHROMEOS)
@@ skipping 171 matching lines @@
 void HelpHandler::OnCurrentChannel(const std::string& channel) {
   web_ui()->CallJavascriptFunction(
       "help.HelpPage.updateCurrentChannel", base::StringValue(channel));
 }
 
 void HelpHandler::OnTargetChannel(const std::string& channel) {
   web_ui()->CallJavascriptFunction(
       "help.HelpPage.updateTargetChannel", base::StringValue(channel));
 }
 
-void HelpHandler::ProcessLsbFileInfo(
-    base::PlatformFileError error, const base::PlatformFileInfo& file_info) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-
-  // If |g_build_date_string| is not |NULL|, then the file's information has
-  // already been retrieved by another tab.
-  if (g_build_date_string == NULL) {
-    base::Time time;
-    if (error == base::PLATFORM_FILE_OK) {
-      // Retrieves the time at which the Chrome OS build was created.
-      // Each time a new build is created, /etc/lsb-release is modified with the
-      // new version numbers of the release.
-      time = file_info.last_modified;
-    } else {
-      // If the time of the build cannot be retrieved, return and do not
-      // display the "Build Date" section.
-      return;
-    }
-
-    // Note that this string will be internationalized.
-    string16 build_date = base::TimeFormatFriendlyDate(time);
-    g_build_date_string = Value::CreateStringValue(build_date);
-  }
-
-  web_ui()->CallJavascriptFunction("help.HelpPage.setBuildDate",
-                                   *g_build_date_string);
-}
 #endif // defined(OS_CHROMEOS)