Parse /etc/lsb-release only once on ChromeOS

base/sys_info_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/environment.h"
 #include "base/file_util.h"
 #include "base/sys_info.h"
 #include "base/threading/platform_thread.h"
+#include "base/time/time.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
 typedef PlatformTest SysInfoTest;
 using base::FilePath;
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_ANDROID)
 TEST_F(SysInfoTest, MaxSharedMemorySize) {
   // We aren't actually testing that it's correct, just that it's sane.
   EXPECT_GT(base::SysInfo::MaxSharedMemorySize(), 0u);
@@ skipping 12 matching lines @@
 }
 
 TEST_F(SysInfoTest, AmountOfFreeDiskSpace) {
   // We aren't actually testing that it's correct, just that it's sane.
   FilePath tmp_path;
   ASSERT_TRUE(file_util::GetTempDir(&tmp_path));
   EXPECT_GT(base::SysInfo::AmountOfFreeDiskSpace(tmp_path), 0)
             << tmp_path.value();
 }
 
-#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS)
+#if defined(OS_WIN) || defined(OS_MACOSX)
 TEST_F(SysInfoTest, OperatingSystemVersionNumbers) {
   int32 os_major_version = -1;
   int32 os_minor_version = -1;
   int32 os_bugfix_version = -1;
   base::SysInfo::OperatingSystemVersionNumbers(&os_major_version,
                                                &os_minor_version,
                                                &os_bugfix_version);
   EXPECT_GT(os_major_version, -1);
   EXPECT_GT(os_minor_version, -1);
   EXPECT_GT(os_bugfix_version, -1);
 }
 #endif
 
 TEST_F(SysInfoTest, Uptime) {
   int64 up_time_1 = base::SysInfo::Uptime();
   // UpTime() is implemented internally using TimeTicks::Now(), which documents
   // system resolution as being 1-15ms. Sleep a little longer than that.
   base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(20));
   int64 up_time_2 = base::SysInfo::Uptime();
   EXPECT_GT(up_time_1, 0);
   EXPECT_GT(up_time_2, up_time_1);
 }
 
 #if defined(OS_CHROMEOS)
+
 TEST_F(SysInfoTest, GoogleChromeOSVersionNumbers) {
   int32 os_major_version = -1;
   int32 os_minor_version = -1;
   int32 os_bugfix_version = -1;
-  std::string lsb_release("FOO=1234123.34.5\n");
-  lsb_release.append(base::SysInfo::GetLinuxStandardBaseVersionKey());
-  lsb_release.append("=1.2.3.4\n");
-  base::SysInfo::ParseLsbRelease(lsb_release,
-                                 &os_major_version,
-                                 &os_minor_version,
-                                 &os_bugfix_version);
+  const char* kLsbRelease =
+      "FOO=1234123.34.5\n"
+      "CHROMEOS_RELEASE_VERSION=1.2.3.4\n";
+  base::SysInfo::SetChromeOSVersionInfoForTest(kLsbRelease, base::Time());
+  base::SysInfo::OperatingSystemVersionNumbers(&os_major_version,
+                                               &os_minor_version,
+                                               &os_bugfix_version);
   EXPECT_EQ(1, os_major_version);
   EXPECT_EQ(2, os_minor_version);
   EXPECT_EQ(3, os_bugfix_version);
 }
 
 TEST_F(SysInfoTest, GoogleChromeOSVersionNumbersFirst) {
   int32 os_major_version = -1;
   int32 os_minor_version = -1;
   int32 os_bugfix_version = -1;
-  std::string lsb_release(base::SysInfo::GetLinuxStandardBaseVersionKey());
-  lsb_release.append("=1.2.3.4\n");
-  lsb_release.append("FOO=1234123.34.5\n");
-  base::SysInfo::ParseLsbRelease(lsb_release,
-                                 &os_major_version,
-                                 &os_minor_version,
-                                 &os_bugfix_version);
+  const char* kLsbRelease =
+      "CHROMEOS_RELEASE_VERSION=1.2.3.4\n"
+      "FOO=1234123.34.5\n";
+  base::SysInfo::SetChromeOSVersionInfoForTest(kLsbRelease, base::Time());
+  base::SysInfo::OperatingSystemVersionNumbers(&os_major_version,
+                                               &os_minor_version,
+                                               &os_bugfix_version);
   EXPECT_EQ(1, os_major_version);
   EXPECT_EQ(2, os_minor_version);
   EXPECT_EQ(3, os_bugfix_version);
 }
 
 TEST_F(SysInfoTest, GoogleChromeOSNoVersionNumbers) {
   int32 os_major_version = -1;
   int32 os_minor_version = -1;
   int32 os_bugfix_version = -1;
-  std::string lsb_release("FOO=1234123.34.5\n");
-  base::SysInfo::ParseLsbRelease(lsb_release,
-                                 &os_major_version,
-                                 &os_minor_version,
-                                 &os_bugfix_version);
-  EXPECT_EQ(-1, os_major_version);
-  EXPECT_EQ(-1, os_minor_version);
-  EXPECT_EQ(-1, os_bugfix_version);
+  const char* kLsbRelease = "FOO=1234123.34.5\n";
+  base::SysInfo::SetChromeOSVersionInfoForTest(kLsbRelease, base::Time());
+  base::SysInfo::OperatingSystemVersionNumbers(&os_major_version,
+                                               &os_minor_version,
+                                               &os_bugfix_version);
+  EXPECT_EQ(0, os_major_version);
+  EXPECT_EQ(0, os_minor_version);
+  EXPECT_EQ(0, os_bugfix_version);
+}
+
+TEST_F(SysInfoTest, GoogleChromeOSLsbReleaseTime) {
+  const char* kLsbRelease = "CHROMEOS_RELEASE_VERSION=1.2.3.4";
+  base::Time lsb_release_time = base::Time::Now();
+  base::SysInfo::SetChromeOSVersionInfoForTest(kLsbRelease, lsb_release_time);
+  base::Time parsed_lsb_release_time = base::SysInfo::GetLsbReleaseTime();
+  EXPECT_EQ(lsb_release_time.ToDoubleT(),
+            parsed_lsb_release_time.ToDoubleT());
 }
 
 #endif  // OS_CHROMEOS