Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: src/assembler.h

Issue 23588002: cleanup api callbacks now that handles are never returned directly (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: nits Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 637
638 // Builtin call that returns floating point. 638 // Builtin call that returns floating point.
639 // double f(double). 639 // double f(double).
640 BUILTIN_FP_CALL, 640 BUILTIN_FP_CALL,
641 641
642 // Builtin call that returns floating point. 642 // Builtin call that returns floating point.
643 // double f(double, int). 643 // double f(double, int).
644 BUILTIN_FP_INT_CALL, 644 BUILTIN_FP_INT_CALL,
645 645
646 // Direct call to API function callback. 646 // Direct call to API function callback.
647 // Handle<Value> f(v8::Arguments&) 647 // void f(v8::FunctionCallbackInfo&)
648 DIRECT_API_CALL, 648 DIRECT_API_CALL,
649 649
650 // Call to invocation callback via InvokeInvocationCallback. 650 // Call to function callback via InvokeFunctionCallback.
651 // Handle<Value> f(v8::Arguments&, v8::InvocationCallback) 651 // void f(v8::FunctionCallbackInfo&, v8::FunctionCallback)
652 PROFILING_API_CALL, 652 PROFILING_API_CALL,
653 653
654 // Direct call to API function callback.
655 // void f(v8::Arguments&)
656 DIRECT_API_CALL_NEW,
657
658 // Call to function callback via InvokeFunctionCallback.
659 // void f(v8::Arguments&, v8::FunctionCallback)
660 PROFILING_API_CALL_NEW,
661
662 // Direct call to accessor getter callback. 654 // Direct call to accessor getter callback.
663 // Handle<value> f(Local<String> property, AccessorInfo& info) 655 // void f(Local<String> property, PropertyCallbackInfo& info)
664 DIRECT_GETTER_CALL, 656 DIRECT_GETTER_CALL,
665 657
666 // Call to accessor getter callback via InvokeAccessorGetter.
667 // Handle<value> f(Local<String> property, AccessorInfo& info,
668 // AccessorGetter getter)
669 PROFILING_GETTER_CALL,
670
671 // Direct call to accessor getter callback.
672 // void f(Local<String> property, AccessorInfo& info)
673 DIRECT_GETTER_CALL_NEW,
674
675 // Call to accessor getter callback via InvokeAccessorGetterCallback. 658 // Call to accessor getter callback via InvokeAccessorGetterCallback.
676 // void f(Local<String> property, AccessorInfo& info, 659 // void f(Local<String> property, PropertyCallbackInfo& info,
677 // AccessorGetterCallback callback) 660 // AccessorGetterCallback callback)
678 PROFILING_GETTER_CALL_NEW 661 PROFILING_GETTER_CALL
679 }; 662 };
680 663
681 static void SetUp(); 664 static void SetUp();
682 static void InitializeMathExpData(); 665 static void InitializeMathExpData();
683 static void TearDownMathExpData(); 666 static void TearDownMathExpData();
684 667
685 typedef void* ExternalReferenceRedirector(void* original, Type type); 668 typedef void* ExternalReferenceRedirector(void* original, Type type);
686 669
687 ExternalReference() : address_(NULL) {} 670 ExternalReference() : address_(NULL) {}
688 671
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
1074 public: 1057 public:
1075 NullCallWrapper() { } 1058 NullCallWrapper() { }
1076 virtual ~NullCallWrapper() { } 1059 virtual ~NullCallWrapper() { }
1077 virtual void BeforeCall(int call_size) const { } 1060 virtual void BeforeCall(int call_size) const { }
1078 virtual void AfterCall() const { } 1061 virtual void AfterCall() const { }
1079 }; 1062 };
1080 1063
1081 } } // namespace v8::internal 1064 } } // namespace v8::internal
1082 1065
1083 #endif // V8_ASSEMBLER_H_ 1066 #endif // V8_ASSEMBLER_H_
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698