Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 2358793002: Add setBounds to SkLiteDL for Android (Closed)

Created:
4 years, 3 months ago by liyuqian
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add setBounds to SkLiteDL for Android The RootRenderNode in Android is changing bounds dynamically. This is a temporary fix to accomodate that behaviour. (See also b/31304115) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358793002 Committed: https://skia.googlesource.com/skia/+/71477bdfb08bed2a6daeac9fc03930dedb68bc2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/core/SkLiteDL.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkLiteDL.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
liyuqian
Here's the corresponding patch for the skia repository.
4 years, 3 months ago (2016-09-21 13:37:09 UTC) #4
mtklein
lgtm
4 years, 3 months ago (2016-09-21 13:37:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358793002/1
4 years, 3 months ago (2016-09-21 13:38:02 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 14:11:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/71477bdfb08bed2a6daeac9fc03930dedb68bc2b

Powered by Google App Engine
This is Rietveld 408576698