components/password_manager/core/browser/password_generation_manager_unittest.cc - Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager_unittest.cc

Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr (Closed)

Patch Set: Change Comment nullptr to null Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/omnibox/browser/zero_suggest_provider_unittest.cc ('k') | components/safe_browsing_db/remote_database_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_generation_manager_unittest.cc b/components/password_manager/core/browser/password_generation_manager_unittest.cc

index 5a3aedc684e71628355a37a643d87d6bc800cc51..1ca939ab885baea53376ab728e0a33260afe154a 100644

--- a/components/password_manager/core/browser/password_generation_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_generation_manager_unittest.cc

@@ -8,6 +8,7 @@

#include <utility>

#include <vector>

+#include "base/memory/ptr_util.h"

#include "base/message_loop/message_loop.h"

#include "base/metrics/field_trial.h"

#include "base/strings/utf_string_conversions.h"

@@ -271,8 +272,8 @@ TEST_F(PasswordGenerationManagerTest, CheckIfFormClassifierShouldRun) {

std::unique_ptr<base::FieldTrialList> field_trial_list;

scoped_refptr<base::FieldTrial> field_trial;

if (is_autofill_field_metadata_enabled) {

- field_trial_list.reset(

- new base::FieldTrialList(new metrics::SHA1EntropyProvider("foo")));

+ field_trial_list.reset(new base::FieldTrialList(

+ base::MakeUnique<metrics::SHA1EntropyProvider>("foo")));

field_trial = base::FieldTrialList::CreateFieldTrial(

"AutofillFieldMetadata", "Enabled");

EXPECT_CALL(*GetTestDriver(), AllowToRunFormClassifier())