components/omnibox/browser/keyword_provider_unittest.cc - Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/keyword_provider_unittest.cc

Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr (Closed)

Patch Set: Change Comment nullptr to null Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/keyword_provider_unittest.cc

diff --git a/components/omnibox/browser/keyword_provider_unittest.cc b/components/omnibox/browser/keyword_provider_unittest.cc

index e74396d8adbc79f1e8c0d480558d71ef5a454bde..8c4e4bf7d8d5d646436fdf67e629d99ba35fb5bc 100644

--- a/components/omnibox/browser/keyword_provider_unittest.cc

+++ b/components/omnibox/browser/keyword_provider_unittest.cc

@@ -63,7 +63,7 @@ class KeywordProviderTest : public testing::Test {

// a DCHECK.

field_trial_list_.reset();

field_trial_list_.reset(new base::FieldTrialList(

- new metrics::SHA1EntropyProvider("foo")));

+ base::MakeUnique<metrics::SHA1EntropyProvider>("foo")));

variations::testing::ClearAllVariationParams();

}

~KeywordProviderTest() override {}