components/network_session_configurator/network_session_configurator_unittest.cc - Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr (Closed)

Patch Set: Change Comment nullptr to null Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/personal_data_manager_unittest.cc ('k') | components/network_time/network_time_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/network_session_configurator/network_session_configurator_unittest.cc

diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc

index 5a23dffb658bc5ec7edec83b27d27c147bbdef5d..26e5ad9ebff63c3c217e3f3d5548d6ef2c1f7791 100644

--- a/components/network_session_configurator/network_session_configurator_unittest.cc

+++ b/components/network_session_configurator/network_session_configurator_unittest.cc

@@ -7,6 +7,7 @@

#include <map>

#include <memory>

+#include "base/memory/ptr_util.h"

#include "base/metrics/field_trial.h"

#include "base/test/mock_entropy_provider.h"

#include "components/variations/variations_associated_data.h"

@@ -21,7 +22,8 @@ class NetworkSessionConfiguratorTest : public testing::Test {

NetworkSessionConfiguratorTest()

: quic_user_agent_id_("Chrome/52.0.2709.0 Linux x86_64") {

field_trial_list_.reset(

- new base::FieldTrialList(new base::MockEntropyProvider()));

+ new base::FieldTrialList(

+ base::MakeUnique<base::MockEntropyProvider>()));

variations::testing::ClearAllVariationParams();

}