chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc - Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr (Closed)

Patch Set: Change Comment nullptr to null Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc ('k') | chrome/browser/search/instant_unittest_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

index a35426e079327efd33a40c91dca5a749f2d654b6..2a726d2687c75d95556a93b1e5bc72280967095d 100644

--- a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

@@ -389,7 +389,8 @@ TEST_F(LastDownloadFinderTest, NonBinaryOnly) {

// enabled.

TEST_F(LastDownloadFinderTest, SimpleEndToEndFieldTrial) {

// Set up a field trial

- base::FieldTrialList field_trial_list(new base::MockEntropyProvider());

+ base::FieldTrialList field_trial_list(

+ base::MakeUnique<base::MockEntropyProvider>());

base::FieldTrialList::CreateFieldTrial("SafeBrowsingIncidentReportingService",

"Enabled");

// Create a profile with a history service that is opted-in to Safe Browsing