chrome/browser/profile_resetter/triggered_profile_resetter_win_unittest.cc - Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profile_resetter/triggered_profile_resetter_win_unittest.cc

Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr (Closed)

Patch Set: Change Comment nullptr to null Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/predictors/resource_prefetch_common_unittest.cc ('k') | chrome/browser/safe_browsing/client_side_model_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profile_resetter/triggered_profile_resetter_win_unittest.cc

diff --git a/chrome/browser/profile_resetter/triggered_profile_resetter_win_unittest.cc b/chrome/browser/profile_resetter/triggered_profile_resetter_win_unittest.cc

index 0d1780f6cb0e82cd43fef0fed9730715768f8802..a2cc1b98b2a6f4fa6f4e79ea1be723856406e741 100644

--- a/chrome/browser/profile_resetter/triggered_profile_resetter_win_unittest.cc

+++ b/chrome/browser/profile_resetter/triggered_profile_resetter_win_unittest.cc

@@ -9,6 +9,7 @@

#include <memory>

#include "base/bit_cast.h"

+#include "base/memory/ptr_util.h"

#include "base/metrics/field_trial.h"

#include "base/test/test_reg_util_win.h"

#include "base/win/registry.h"

@@ -30,7 +31,8 @@ class TriggeredProfileResetterTest : public testing::Test {

// Activate the triggered reset field trial for these tests.

field_trial_list_.reset(

- new base::FieldTrialList(new metrics::SHA1EntropyProvider("foo")));

+ new base::FieldTrialList(

+ base::MakeUnique<metrics::SHA1EntropyProvider>("foo")));

base::FieldTrial* trial = base::FieldTrialList::CreateFieldTrial(

"TriggeredResetFieldTrial", "On");

trial->group();