chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api_unittest.cc - Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api_unittest.cc

Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr (Closed)

Patch Set: Change Comment nullptr to null Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client_unittest.cc ('k') | chrome/browser/extensions/extension_service_sync_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api_unittest.cc

diff --git a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api_unittest.cc b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api_unittest.cc

index 8cc23994ef6ff6c60c9ef12f90d6ae42bb8a174a..e71b6037c51dc45dfa2c4b83a94561e8a57cb0e7 100644

--- a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api_unittest.cc

+++ b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api_unittest.cc

@@ -19,7 +19,7 @@ typedef ExtensionApiUnittest ExperienceSamplingPrivateTest;

TEST_F(ExperienceSamplingPrivateTest, GetBrowserInfoTest) {

// Start with an empty FieldTrialList.

std::unique_ptr<base::FieldTrialList> trial_list(

- new base::FieldTrialList(NULL));

+ new base::FieldTrialList(nullptr));

std::unique_ptr<base::DictionaryValue> result(RunFunctionAndReturnDictionary(

new ExperienceSamplingPrivateGetBrowserInfoFunction(), "[]"));

ASSERT_TRUE(result->HasKey("variations"));