Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2675)

Unified Diff: base/metrics/field_trial.h

Issue 2358723002: Convert FieldTrialList to Accept a std::unique_ptr (Closed)
Patch Set: Change Comment nullptr to null Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/metrics/field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/field_trial.h
diff --git a/base/metrics/field_trial.h b/base/metrics/field_trial.h
index 28a4606a88438d2d0c68687e24c34a14d3313fa7..2b8894904dd350e94899581bd858506300e83cd7 100644
--- a/base/metrics/field_trial.h
+++ b/base/metrics/field_trial.h
@@ -58,6 +58,7 @@
#include <stdint.h>
#include <map>
+#include <memory>
#include <set>
#include <string>
#include <vector>
@@ -338,11 +339,12 @@ class BASE_EXPORT FieldTrialList {
// This singleton holds the global list of registered FieldTrials.
//
- // To support one-time randomized field trials, specify a non-NULL
+ // To support one-time randomized field trials, specify a non-null
// |entropy_provider| which should be a source of uniformly distributed
- // entropy values. Takes ownership of |entropy_provider|. If one time
- // randomization is not desired, pass in NULL for |entropy_provider|.
- explicit FieldTrialList(const FieldTrial::EntropyProvider* entropy_provider);
+ // entropy values. If one time randomization is not desired, pass in null for
+ // |entropy_provider|.
+ explicit FieldTrialList(
+ std::unique_ptr<const FieldTrial::EntropyProvider> entropy_provider);
// Destructor Release()'s references to all registered FieldTrial instances.
~FieldTrialList();
« no previous file with comments | « no previous file | base/metrics/field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698