Convert FieldTrialList to Accept a std::unique_ptr

base/metrics/field_trial.h

Index: base/metrics/field_trial.h
diff --git a/base/metrics/field_trial.h b/base/metrics/field_trial.h
index 28a4606a88438d2d0c68687e24c34a14d3313fa7..f502d89e988976eac0f23fb6ae9ac5f93793bfdc 100644
--- a/base/metrics/field_trial.h
+++ b/base/metrics/field_trial.h
@@ -58,6 +58,7 @@
 #include <stdint.h>
 
 #include <map>
+#include <memory>
 #include <set>
 #include <string>
 #include <vector>
@@ -338,11 +339,12 @@ class BASE_EXPORT FieldTrialList {
 
   // This singleton holds the global list of registered FieldTrials.
   //
-  // To support one-time randomized field trials, specify a non-NULL
+  // To support one-time randomized field trials, specify a non-nullptr
   // |entropy_provider| which should be a source of uniformly distributed
-  // entropy values. Takes ownership of |entropy_provider|. If one time
-  // randomization is not desired, pass in NULL for |entropy_provider|.
-  explicit FieldTrialList(const FieldTrial::EntropyProvider* entropy_provider);
+  // entropy values. If one time randomization is not desired, pass in nullptr

[Alexei Svitkine (slow), 2016/09/21 15:52:00]

Nit: I think in comments just using "null" rather than "nullptr" is preferred -
since it's talking about the concept of null. I remember that was the conclusion
from the chromium-dev@ thread where we first discussed using nullptr in Chromium
instead of NULL.

[robliao, 2016/09/21 17:24:29]

Change this to lowercase null then to deemphasize the use of NULL.

+  // for |entropy_provider|.
+  explicit FieldTrialList(
+      std::unique_ptr<const FieldTrial::EntropyProvider> entropy_provider);
 
   // Destructor Release()'s references to all registered FieldTrial instances.
   ~FieldTrialList();