Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2358713002:
Adding SwiftShader compilation to Mac (Closed)
DescriptionAdding SwiftShader compilation to Mac
TBR=thakis@chromium.org
BUG=630728
Committed: https://crrev.com/8287bfde58028afa246a83372bf25fe2f3e2a15c
Cr-Commit-Position: refs/heads/master@{#431682}
Patch Set 1 #Patch Set 2 : Adding SwiftShader compilation to Mac #Patch Set 3 : Trying out mac build with new version of SwiftShader #
Total comments: 2
Patch Set 4 : Trying out Mac build fix #Patch Set 5 : Adding fix to unstripped outputs #
Total comments: 2
Patch Set 6 : New version of SwiftShader #Patch Set 7 : Verify Windows #Patch Set 8 : Update to ToT #Patch Set 9 : Adding SwiftShader compilation to Mac #Messages
Total messages: 22 (9 generated)
https://codereview.chromium.org/2358713002/diff/40001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2358713002/diff/40001/BUILD.gn#newcode503 BUILD.gn:503: if (is_win || is_linux) { This is Linux and not Mac like the commit message says.
sugoi@google.com changed reviewers: + sugoi@google.com
https://codereview.chromium.org/2358713002/diff/40001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2358713002/diff/40001/BUILD.gn#newcode503 BUILD.gn:503: if (is_win || is_linux) { On 2016/09/21 15:48:26, Corentin Wallez wrote: > This is Linux and not Mac like the commit message says. Oh, this doesn't matter for now. I committed this by mistake, but the swiftshader compilation on mac is enabled in the other BUILD.gn file.
As on the other issue, please just randomly add try bots. This runs on win_archive and win_x64_archive, both of which run on a tiny pool of 2 slaves shared with other bots, and these two slaves are now blocked due to them needlessly running jobs for this CL.
On 2016/09/21 16:56:15, Nico wrote: > As on the other issue, please just randomly add try bots. This runs on > win_archive and win_x64_archive, both of which run on a tiny pool of 2 slaves > shared with other bots, and these two slaves are now blocked due to them > needlessly running jobs for this CL. Noted
Description was changed from ========== Adding SwiftShader compilation to Mac This is just a compilation test for now. BUG= ========== to ========== Adding SwiftShader compilation to Mac This is just a compilation test for now. BUG= ==========
rsesek@chromium.org changed reviewers: + rsesek@chromium.org
https://codereview.chromium.org/2358713002/diff/80001/chrome/BUILD.gn File chrome/BUILD.gn (right): https://codereview.chromium.org/2358713002/diff/80001/chrome/BUILD.gn#newcode462 chrome/BUILD.gn:462: "//third_party/swiftshader", This doesn't belong on this target, which is just a forwarding group. If this target is meant to get linked into chrome, it needs to go into the framework.
https://codereview.chromium.org/2358713002/diff/80001/chrome/BUILD.gn File chrome/BUILD.gn (right): https://codereview.chromium.org/2358713002/diff/80001/chrome/BUILD.gn#newcode462 chrome/BUILD.gn:462: "//third_party/swiftshader", On 2016/09/21 21:23:43, Robert Sesek wrote: > This doesn't belong on this target, which is just a forwarding group. If this > target is meant to get linked into chrome, it needs to go into the framework. This code won't land, this is purely for test purposes. The final code will only include swiftshader in the top level BUILD.gn file, within the 'all' target (It's already there on Windows). But too many build bots only build 'chrome', so I use this temporarily for test purposes.
Description was changed from ========== Adding SwiftShader compilation to Mac This is just a compilation test for now. BUG= ========== to ========== Adding SwiftShader compilation to Mac This is just a compilation test for now. TBR=thakis@chromium.org BUG=630728 ==========
sugoi@chromium.org changed reviewers: - rsesek@chromium.org
Description was changed from ========== Adding SwiftShader compilation to Mac This is just a compilation test for now. TBR=thakis@chromium.org BUG=630728 ========== to ========== Adding SwiftShader compilation to Mac TBR=thakis@chromium.org BUG=630728 ==========
The CQ bit was checked by sugoi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Adding SwiftShader compilation to Mac TBR=thakis@chromium.org BUG=630728 ========== to ========== Adding SwiftShader compilation to Mac TBR=thakis@chromium.org BUG=630728 ==========
Message was sent while issue was closed.
Committed patchset #9 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Adding SwiftShader compilation to Mac TBR=thakis@chromium.org BUG=630728 ========== to ========== Adding SwiftShader compilation to Mac TBR=thakis@chromium.org BUG=630728 Committed: https://crrev.com/8287bfde58028afa246a83372bf25fe2f3e2a15c Cr-Commit-Position: refs/heads/master@{#431682} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/8287bfde58028afa246a83372bf25fe2f3e2a15c Cr-Commit-Position: refs/heads/master@{#431682}
Message was sent while issue was closed.
Reverted here: https://codereview.chromium.org/2517053003
Message was sent while issue was closed.
On 2016/11/21 22:02:55, sugoi1 wrote: > Reverted here: > https://codereview.chromium.org/2517053003 Oops, not reverted, the linux compilation was reverted, not the Mac compilation. |
