Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 23587012: Remove guest icon and update screen text according to new approved UI. (Closed)

Created:
7 years, 3 months ago by bcwhite
Modified:
7 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Remove guest icon and update screen text according to new approved UI. BUG=103846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221720

Patch Set 1 #

Patch Set 2 : use conditions in resources instead of code #

Patch Set 3 : restore original android page content #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +16 lines, -6 lines 3 comments Download
M chrome/browser/resources/ntp4/guest_tab.html View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/webui/resources/images/guest_icon_standalone.png View Binary file 0 comments Download

Messages

Total messages: 10 (0 generated)
bcwhite
use conditions in resources instead of code
7 years, 3 months ago (2013-09-04 17:15:49 UTC) #1
bcwhite
restore original android page content
7 years, 3 months ago (2013-09-04 17:19:53 UTC) #2
bcwhite
Evan, this is new CL that does the same as the previous one you reviewed ...
7 years, 3 months ago (2013-09-05 15:32:56 UTC) #3
Evan Stade
cool https://codereview.chromium.org/23587012/diff/1005/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/23587012/diff/1005/chrome/app/generated_resources.grd#newcode10712 chrome/app/generated_resources.grd:10712: + <if expr="not pp_ifdef('chromeos')"> can you narrow the ...
7 years, 3 months ago (2013-09-05 17:08:30 UTC) #4
Evan Stade
https://codereview.chromium.org/23587012/diff/1005/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/23587012/diff/1005/chrome/app/generated_resources.grd#newcode10712 chrome/app/generated_resources.grd:10712: + <if expr="not pp_ifdef('chromeos')"> On 2013/09/05 17:08:30, Evan Stade ...
7 years, 3 months ago (2013-09-05 17:09:29 UTC) #5
bcwhite
https://codereview.chromium.org/23587012/diff/1005/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/23587012/diff/1005/chrome/app/generated_resources.grd#newcode10712 chrome/app/generated_resources.grd:10712: + <if expr="not pp_ifdef('chromeos')"> > can you narrow the ...
7 years, 3 months ago (2013-09-05 20:07:00 UTC) #6
bcwhite
It looks to me like it'll likely mess up the strings as they're passed off ...
7 years, 3 months ago (2013-09-05 20:17:08 UTC) #7
Evan Stade
lgtm
7 years, 3 months ago (2013-09-05 22:46:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/23587012/1005
7 years, 3 months ago (2013-09-06 13:20:23 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 17:11:36 UTC) #10
Message was sent while issue was closed.
Change committed as 221720

Powered by Google App Engine
This is Rietveld 408576698