Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

Issue 2358683002: Android: enable/disable WebRTC HW H264 with a flag. (Closed)
Patch Set: expanding existing switch flag instead of add one more feature Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
diff --git a/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java b/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
index 0c012de85d6262bebf419bea6da5cb0539ca488f..5f24f37b0751abbdb90ef9e5de2824dc44162f11 100644
--- a/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
+++ b/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
@@ -29,7 +29,7 @@ import java.nio.ByteBuffer;
*/
@JNINamespace("media")
class MediaCodecBridge {
- private static final String TAG = "cr_media";
+ private static final String TAG = "cr_MediaCodecBridge";
// Error code for MediaCodecBridge. Keep this value in sync with
// MediaCodecStatus in media_codec_bridge.h.
@@ -207,8 +207,7 @@ class MediaCodecBridge {
MediaCodecUtil.CodecCreationInfo info = new MediaCodecUtil.CodecCreationInfo();
try {
if (direction == MediaCodecUtil.MEDIA_CODEC_ENCODER) {
- info.mediaCodec = MediaCodec.createEncoderByType(mime);
- info.supportsAdaptivePlayback = false;
+ info = MediaCodecUtil.createEncoder(mime);
} else {
// |isSecure| only applies to video decoders.
info = MediaCodecUtil.createDecoder(mime, isSecure, requireSoftwareCodec);
@@ -376,6 +375,7 @@ class MediaCodecBridge {
Bundle b = new Bundle();
b.putInt(MediaCodec.PARAMETER_KEY_VIDEO_BITRATE, bps);
mMediaCodec.setParameters(b);
+ Log.v(TAG, "setVideoBitrate " + bps);
}
@TargetApi(Build.VERSION_CODES.KITKAT)
@@ -569,6 +569,7 @@ class MediaCodecBridge {
format.setInteger(MediaFormat.KEY_FRAME_RATE, frameRate);
format.setInteger(MediaFormat.KEY_I_FRAME_INTERVAL, iFrameInterval);
format.setInteger(MediaFormat.KEY_COLOR_FORMAT, colorFormat);
+ Log.d(TAG, "video encoder format: " + format);
return format;
}

Powered by Google App Engine
This is Rietveld 408576698