content/renderer/media/webrtc/peer_connection_dependency_factory.cc - Issue 2358683002: Android: enable/disable WebRTC HW H264 with a flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

Issue 2358683002: Android: enable/disable WebRTC HW H264 with a flag. (Closed)

Patch Set: add back the removed entry in software_rendering_list_jason.cc and remove the change in gpu_data_manager_impl_private.cc Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/gpu/rtc_video_encoder_factory.cc ('k') | gpu/config/software_rendering_list_json.cc » ('j') | gpu/config/software_rendering_list_json.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

diff --git a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

index 065993d290c91daf53c22407dd568f2d31217a08..2f4bade656d5e109010c114e978bbd9196773085 100644

--- a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

+++ b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

@@ -257,8 +257,11 @@ void PeerConnectionDependencyFactory::InitializeSignalingThread(

if (!cmd_line->HasSwitch(switches::kDisableWebRtcHWDecoding))

decoder_factory.reset(new RTCVideoDecoderFactory(gpu_factories));

- if (!cmd_line->HasSwitch(switches::kDisableWebRtcHWEncoding))

+ if (!cmd_line->HasSwitch(switches::kDisableWebRtcHWEncoding) ||

+ !cmd_line->GetSwitchValueASCII(switches::kDisableWebRtcHWEncoding)

+ .empty()) {

encoder_factory.reset(new RTCVideoEncoderFactory(gpu_factories));

+ }

}

#if defined(OS_ANDROID)