Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2358683002: Android: enable/disable WebRTC HW H264 with a flag. (Closed)
Patch Set: adopt enum instead and address other comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 switches::kMaterialSecurityVerboseShowAllNonAnimated}, 659 switches::kMaterialSecurityVerboseShowAllNonAnimated},
660 {IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_SHOW_NONSECURE_ANIMATED, 660 {IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_SHOW_NONSECURE_ANIMATED,
661 switches::kMaterialSecurityVerbose, 661 switches::kMaterialSecurityVerbose,
662 switches::kMaterialSecurityVerboseShowNonSecureAnimated}, 662 switches::kMaterialSecurityVerboseShowNonSecureAnimated},
663 {IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_SHOW_NONSECURE_NONANIMATED, 663 {IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_SHOW_NONSECURE_NONANIMATED,
664 switches::kMaterialSecurityVerbose, 664 switches::kMaterialSecurityVerbose,
665 switches::kMaterialSecurityVerboseShowNonSecureNonAnimated}, 665 switches::kMaterialSecurityVerboseShowNonSecureNonAnimated},
666 }; 666 };
667 #endif // defined(OS_MACOSX) 667 #endif // defined(OS_MACOSX)
668 668
669 #if defined(ENABLE_WEBRTC)
670 const FeatureEntry::Choice kDisableWebRtcHWEncodingChoices[] = {
671 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
672 {IDS_FLAGS_WEBRTC_HW_ENCODING_ALL, switches::kDisableWebRtcHWEncoding, ""},
673 {IDS_FLAGS_WEBRTC_HW_ENCODING_VPX, switches::kDisableWebRtcHWEncoding,
674 switches::kDisableWebRtcHWEncodingVPx},
675 {IDS_FLAGS_WEBRTC_HW_ENCODING_H264, switches::kDisableWebRtcHWEncoding,
676 switches::kDisableWebRtcHWEncodingH264},
677 {IDS_FLAGS_WEBRTC_HW_ENCODING_NONE, switches::kDisableWebRtcHWEncoding,
678 switches::kDisableWebRtcHWEncodingNone},
679 };
680 #endif
681
669 // RECORDING USER METRICS FOR FLAGS: 682 // RECORDING USER METRICS FOR FLAGS:
670 // ----------------------------------------------------------------------------- 683 // -----------------------------------------------------------------------------
671 // The first line of the entry is the internal name. 684 // The first line of the entry is the internal name.
672 // 685 //
673 // To add a new entry, add to the end of kFeatureEntries. There are two 686 // To add a new entry, add to the end of kFeatureEntries. There are two
674 // distinct types of entries: 687 // distinct types of entries:
675 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE 688 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE
676 // macro for this type supplying the command line to the macro. 689 // macro for this type supplying the command line to the macro.
677 // . MULTI_VALUE: a list of choices, the first of which should correspond to a 690 // . MULTI_VALUE: a list of choices, the first of which should correspond to a
678 // deactivated state for this lab (i.e. no command line option). To specify 691 // deactivated state for this lab (i.e. no command line option). To specify
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 {"gl-composited-texture-quad-borders", 728 {"gl-composited-texture-quad-borders",
716 IDS_FLAGS_GL_COMPOSITED_TEXTURE_QUAD_BORDERS, 729 IDS_FLAGS_GL_COMPOSITED_TEXTURE_QUAD_BORDERS,
717 IDS_FLAGS_GL_COMPOSITED_TEXTURE_QUAD_BORDERS_DESCRIPTION, kOsAll, 730 IDS_FLAGS_GL_COMPOSITED_TEXTURE_QUAD_BORDERS_DESCRIPTION, kOsAll,
718 SINGLE_VALUE_TYPE(cc::switches::kGlCompositedTextureQuadBorder)}, 731 SINGLE_VALUE_TYPE(cc::switches::kGlCompositedTextureQuadBorder)},
719 #if defined(ENABLE_WEBRTC) 732 #if defined(ENABLE_WEBRTC)
720 {"disable-webrtc-hw-decoding", IDS_FLAGS_WEBRTC_HW_DECODING_NAME, 733 {"disable-webrtc-hw-decoding", IDS_FLAGS_WEBRTC_HW_DECODING_NAME,
721 IDS_FLAGS_WEBRTC_HW_DECODING_DESCRIPTION, kOsAndroid | kOsCrOS, 734 IDS_FLAGS_WEBRTC_HW_DECODING_DESCRIPTION, kOsAndroid | kOsCrOS,
722 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableWebRtcHWDecoding)}, 735 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableWebRtcHWDecoding)},
723 {"disable-webrtc-hw-encoding", IDS_FLAGS_WEBRTC_HW_ENCODING_NAME, 736 {"disable-webrtc-hw-encoding", IDS_FLAGS_WEBRTC_HW_ENCODING_NAME,
724 IDS_FLAGS_WEBRTC_HW_ENCODING_DESCRIPTION, kOsAndroid | kOsCrOS, 737 IDS_FLAGS_WEBRTC_HW_ENCODING_DESCRIPTION, kOsAndroid | kOsCrOS,
725 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableWebRtcHWEncoding)}, 738 MULTI_VALUE_TYPE(kDisableWebRtcHWEncodingChoices)},
726 {"enable-webrtc-stun-origin", IDS_FLAGS_WEBRTC_STUN_ORIGIN_NAME, 739 {"enable-webrtc-stun-origin", IDS_FLAGS_WEBRTC_STUN_ORIGIN_NAME,
727 IDS_FLAGS_WEBRTC_STUN_ORIGIN_DESCRIPTION, kOsAll, 740 IDS_FLAGS_WEBRTC_STUN_ORIGIN_DESCRIPTION, kOsAll,
728 SINGLE_VALUE_TYPE(switches::kEnableWebRtcStunOrigin)}, 741 SINGLE_VALUE_TYPE(switches::kEnableWebRtcStunOrigin)},
729 #endif 742 #endif
730 #if defined(OS_ANDROID) 743 #if defined(OS_ANDROID)
731 {"enable-osk-overscroll", IDS_FLAGS_ENABLE_OSK_OVERSCROLL_NAME, 744 {"enable-osk-overscroll", IDS_FLAGS_ENABLE_OSK_OVERSCROLL_NAME,
732 IDS_FLAGS_ENABLE_OSK_OVERSCROLL_DESCRIPTION, kOsAndroid, 745 IDS_FLAGS_ENABLE_OSK_OVERSCROLL_DESCRIPTION, kOsAndroid,
733 SINGLE_VALUE_TYPE(switches::kEnableOSKOverscroll)}, 746 SINGLE_VALUE_TYPE(switches::kEnableOSKOverscroll)},
734 #endif 747 #endif
735 // Native client is compiled out when DISABLE_NACL is defined. 748 // Native client is compiled out when DISABLE_NACL is defined.
(...skipping 1571 matching lines...) Expand 10 before | Expand all | Expand 10 after
2307 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2320 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2308 2321
2309 const FeatureEntry* GetFeatureEntries(size_t* count) { 2322 const FeatureEntry* GetFeatureEntries(size_t* count) {
2310 *count = arraysize(kFeatureEntries); 2323 *count = arraysize(kFeatureEntries);
2311 return kFeatureEntries; 2324 return kFeatureEntries;
2312 } 2325 }
2313 2326
2314 } // namespace testing 2327 } // namespace testing
2315 2328
2316 } // namespace about_flags 2329 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698