Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2358673002: Increase scroll height in scroll tests (Closed)

Created:
4 years, 3 months ago by calvimei
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase scroll height in scroll tests TouchActionBrowserTest.DefaultAuto is flaky on devices which have a longer display than other devices. The test could not scroll the full height of the display, so we increase the scroll height. BUG=648755 Committed: https://crrev.com/a1f33125fea8776f8c3d3edbe6eb194e21549cf5 Cr-Commit-Position: refs/heads/master@{#421300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/renderer_host/input/touch_action_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
calvimei
PTAL
4 years, 2 months ago (2016-09-26 18:42:18 UTC) #3
dtapuska
On 2016/09/26 18:42:18, calvimei wrote: > PTAL lgtm
4 years, 2 months ago (2016-09-26 18:46:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358673002/1
4 years, 2 months ago (2016-09-27 19:00:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 19:42:01 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 19:46:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1f33125fea8776f8c3d3edbe6eb194e21549cf5
Cr-Commit-Position: refs/heads/master@{#421300}

Powered by Google App Engine
This is Rietveld 408576698