Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2358633002: Remove call to MessageLoop::RunUntilIdle from wait_util.mm. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove call to MessageLoop::RunUntilIdle from wait_util.mm. MessageLoop::RunUntilIdle is deprecated. BUG=616447 Committed: https://crrev.com/25556a66237890c3e0ae3be457093f72e1c4a387 Cr-Commit-Position: refs/heads/master@{#420416}

Patch Set 1 #

Patch Set 2 : remove calls to deprecated methods #

Patch Set 3 : add todos #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -38 lines) Patch
M base/test/ios/wait_util.h View 1 2 2 chunks +23 lines, -15 lines 0 comments Download
M base/test/ios/wait_util.mm View 5 chunks +22 lines, -9 lines 2 comments Download
M ios/chrome/browser/reading_list/url_downloader_unittest.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M ios/web/net/crw_cert_verification_controller_unittest.mm View 1 2 chunks +10 lines, -6 lines 0 comments Download
M ios/web/webui/mojo_facade_unittest.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-20 19:04:56 UTC) #2
fdoray
rohitrao@: ping +sdefresne@ in case rohitrao@ isn't available
4 years, 3 months ago (2016-09-22 17:44:10 UTC) #4
rohitrao (ping after 24h)
LGTM Does anyone ever call this function with a message loop that isn't the current ...
4 years, 3 months ago (2016-09-22 17:52:13 UTC) #5
fdoray
On 2016/09/22 17:52:13, rohitrao wrote: > LGTM > > Does anyone ever call this function ...
4 years, 3 months ago (2016-09-22 17:56:53 UTC) #6
fdoray
On 2016/09/22 17:56:53, fdoray wrote: > On 2016/09/22 17:52:13, rohitrao wrote: > > LGTM > ...
4 years, 3 months ago (2016-09-22 18:48:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358633002/40001
4 years, 3 months ago (2016-09-22 18:49:33 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 19:06:58 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/25556a66237890c3e0ae3be457093f72e1c4a387 Cr-Commit-Position: refs/heads/master@{#420416}
4 years, 3 months ago (2016-09-22 19:09:27 UTC) #12
sdefresne
https://codereview.chromium.org/2358633002/diff/40001/base/test/ios/wait_util.mm File base/test/ios/wait_util.mm (right): https://codereview.chromium.org/2358633002/diff/40001/base/test/ios/wait_util.mm#newcode21 base/test/ios/wait_util.mm:21: bool run_message_loop, It look like you are passing "true" ...
4 years, 3 months ago (2016-09-23 09:08:17 UTC) #13
fdoray
4 years, 3 months ago (2016-09-23 12:13:47 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/2358633002/diff/40001/base/test/ios/wait_util.mm
File base/test/ios/wait_util.mm (right):

https://codereview.chromium.org/2358633002/diff/40001/base/test/ios/wait_util...
base/test/ios/wait_util.mm:21: bool run_message_loop,
On 2016/09/23 09:08:17, sdefresne wrote:
> It look like you are passing "true" for this variable in all callsite while
> previously the value was null if MessageLoop::current() was returning null
> (which is possible).
> 
> If this does not break anything, it's good, but there is a semantic change
here.
> 
> In addition, if we only ever call this method with "true", then maybe we
should
> remove the extra parameter.
> 
> WDYT?

You're right, this changes the semantic. But since the CL didn't break anything,
I don't think that MessageLoop::current() returned nullptr at any
TimeUntilCondition() call site before.

In ios_internal, there are call sites where nullptr is passed (will be migrated
to false). Therefore, we can't remove the extra parameter.

Powered by Google App Engine
This is Rietveld 408576698