Remove desktop auto-login since we don't plan on shipping it.

Remove desktop auto-login since we don't plan on shipping it.

Removes the --enable-autologin switch and associated settings UI.  Autologin is
always enabled for Android builds.  Moves the Android-specific AutoLoginPrompter
class into an android/ directory.

iOS also uses the AutoLoginInfoBarDelegate, so that class is left where it is.

BUG=347214
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264818

[rohitrao (ping after 24h), 2014-04-16 19:22:45]

This is an unrevert of codereview Issue 182253004.

It re-applies all changes except the refactoring of the infobar delegate.  Since
the base class is still used by iOS, I dropped the changes that made the infobar
android-specific.

https://codereview.chromium.org/235863025/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.js (left):

https://codereview.chromium.org/235863025/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.js:915: // Move
#enable-auto-login-checkbox to a different location on CrOS.
I deleted this because it seemed autologin-specific.

[Roger Tawa OOO till Jul 10th, 2014-04-16 19:37:35]

lgtm

Thanks for fixing this Rohit, and sorry that I broke iOS with my original CL.

Could you fix the .gypi file to make sure auto_login_infobar_delegate.h|cc are
not compiled at all on desktop platforms?

[rohitrao (ping after 24h), 2014-04-16 20:51:52]

> Could you fix the .gypi file to make sure auto_login_infobar_delegate.h|cc are
> not compiled at all on desktop platforms?

Latest patchset includes gyp changes.  I verified that
auto_login_infobar_delegate.{h,cc} is not compiled on my Mac desktop.

Also verified (on Mac) that:
- There is no #enable-autologin entry on about:flags.
- The autologin checkbox does not appear in settings.
- Visiting gmail.com does not trigger an infobar prompt.

[rohitrao (ping after 24h), 2014-04-16 20:59:47]

Hello new OWNERS reviewers!

This is a re-land of a CL you have already reviewed.  The original CL was
https://codereview.chromium.org/182253004/.  The changes are essentially the
same, except I removed the infobar refactoring to allow iOS to continue using
the base class.

nyquist/tedchoc:
chrome/browser/android/...
chrome/browser/ui/android/...

jhawkins:
chrome/browser/resources/options/...
chrome/browser/ui/webui/options/browser_options_handler.cc

sky:
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
chrome/browser/ui/...

[Ted C, 2014-04-16 21:07:03]

On 2014/04/16 20:59:47, rohitrao wrote:
> Hello new OWNERS reviewers!
> 
> This is a re-land of a CL you have already reviewed.  The original CL was
> https://codereview.chromium.org/182253004/.  The changes are essentially the
> same, except I removed the infobar refactoring to allow iOS to continue using
> the base class.
> 
> nyquist/tedchoc:
> chrome/browser/android/...
> chrome/browser/ui/android/...
> 
> jhawkins:
> chrome/browser/resources/options/...
> chrome/browser/ui/webui/options/browser_options_handler.cc
> 
> sky:
> chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
> chrome/browser/ui/...

android - lgtm

[sky, 2014-04-16 21:35:44]

https://codereview.chromium.org/235863025/diff/40001/chrome/browser/ui/auto_l...
File chrome/browser/ui/auto_login_infobar_delegate.h (right):

https://codereview.chromium.org/235863025/diff/40001/chrome/browser/ui/auto_l...
chrome/browser/ui/auto_login_infobar_delegate.h:22: // class is shared by
Android and iOS, but it is not used on desktop.
Is there a particular reason you need to say this? You're duplicating what the
gyp files say, which means it's easy to get out of sync.

[rohitrao (ping after 24h), 2014-04-16 21:37:17]

>
https://codereview.chromium.org/235863025/diff/40001/chrome/browser/ui/auto_l...
> chrome/browser/ui/auto_login_infobar_delegate.h:22: // class is shared by
> Android and iOS, but it is not used on desktop.
> Is there a particular reason you need to say this? You're duplicating what the
> gyp files say, which means it's easy to get out of sync.

I dropped it in as another reminder that the file is used by iOS, because it's
not actually compiled by any of the iOS bots upstream.  I can revert this
comment change if you'd prefer.

[sky, 2014-04-16 21:40:03]

Nuke comment and LGTM

[rohitrao (ping after 24h), 2014-04-18 13:46:01]

Hi James,

Will you have a chance to take a quick look at this CL today?  I need your
approval for:
chrome/browser/resources/options/...
chrome/browser/ui/webui/options/browser_options_handler.cc

Thanks!

[James Hawkins, 2014-04-18 17:03:35]

lgtm

[rohitrao (ping after 24h), 2014-04-18 17:20:54]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2014-04-18 17:21:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rohitrao@chromium.org/235863025/60001

[commit-bot: I haz the power, 2014-04-18 18:21:30]

Change committed as 264818