Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5926)

Unified Diff: build/config/win/BUILD.gn

Issue 235863024: Make NSS work in GN build on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index 3175b163bb70d093df607f6cd3200e278b9f50dc..42d8c972beeb2e8994ae6c660d54a489663a4961 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -19,7 +19,6 @@ config("sdk") {
"NTDDI_VERSION=0x06020000",
"PSAPI_VERSION=1",
"WIN32",
- "WIN32_LEAN_AND_MEAN",
"WINVER=0x0602",
]
@@ -109,3 +108,24 @@ config("incremental_linking") {
config("no_incremental_linking") {
ldflags = [ "/INCREMENTAL:NO" ]
}
+
+# Character set ----------------------------------------------------------------
+
+# Not including this config means "ansi" (8-bit system codepage).
+config("unicode") {
+ defines = [
+ "_UNICODE",
+ "UNICODE",
+ ]
+}
+
+# Lean and mean ----------------------------------------------------------------
+
+# Some third party code might not compile with WIN32_LEAN_AND_MEAN so we have
+# to have a separate config for it. Remove this config from your target to
+# get the "bloaty and accomidating" version of windows.h.
scottmg 2014/04/16 18:15:02 heh :) -> "accommodating" also, terrible third_pa
+config("lean_and_mean") {
+ defines = [
+ "WIN32_LEAN_AND_MEAN",
+ ]
+}

Powered by Google App Engine
This is Rietveld 408576698