Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: chrome/browser/history/history_database.cc

Issue 235863023: Eliminate the archived history database and clean up related code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_database.cc
diff --git a/chrome/browser/history/history_database.cc b/chrome/browser/history/history_database.cc
index 97b93830e87c3d25df4bfaf2659203393f9d3813..0d663226d7a243a3ed657257db0ad19ef550982a 100644
--- a/chrome/browser/history/history_database.cc
+++ b/chrome/browser/history/history_database.cc
@@ -33,8 +33,7 @@ const char kEarlyExpirationThresholdKey[] = "early_expiration_threshold";
} // namespace
-HistoryDatabase::HistoryDatabase()
- : needs_version_17_migration_(false) {
+HistoryDatabase::HistoryDatabase() {
}
HistoryDatabase::~HistoryDatabase() {
@@ -220,9 +219,6 @@ bool HistoryDatabase::RecreateAllTablesButURL() {
if (!InitSegmentTables())
return false;
- // We also add the supplementary URL indices at this point. This index is
engedy 2014/04/16 18:08:10 Note: There used to be a CreateSupplimentaryURLInd
- // over parts of the URL table that weren't automatically created when the
- // temporary URL table was
CreateKeywordSearchTermsIndices();
return true;
}
@@ -299,12 +295,6 @@ sql::InitStatus HistoryDatabase::EnsureCurrentVersion() {
return sql::INIT_TOO_NEW;
}
- // NOTICE: If you are changing structures for things shared with the archived
- // history file like URLs, visits, or downloads, that will need migration as
- // well. Instead of putting such migration code in this class, it should be
- // in the corresponding file (url_database.cc, etc.) and called from here and
- // from the archived_database.cc.
-
int cur_version = meta_table_.GetVersionNumber();
// Put migration code here
@@ -455,11 +445,6 @@ void HistoryDatabase::MigrateTimeEpoch() {
"UPDATE segment_usage "
"SET time_slot = time_slot + 11644473600000000 "
"WHERE id IN (SELECT id FROM segment_usage WHERE time_slot > 0);"));
-
- // Erase all the full text index files. These will take a while to update and
engedy 2014/04/16 18:08:10 Note: There had been no no full text index anymore
- // are less important, so we just blow them away. Same with the archived
- // database.
- needs_version_17_migration_ = true;
}
#endif

Powered by Google App Engine
This is Rietveld 408576698