base/process/process_util_unittest.cc - Issue 235863012: Re-enable ProcessUtilTest.GetTerminationStatusCrash on Win64 bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/process_util_unittest.cc

Issue 235863012: Re-enable ProcessUtilTest.GetTerminationStatusCrash on Win64 bots (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/process/process_util_unittest.cc

diff --git a/base/process/process_util_unittest.cc b/base/process/process_util_unittest.cc

index 250b06a4a433e9e47ff753fa6fc4bcc17fbf86b2..78c700d9ee500a33aad47ec4dfa4f7628348c90e 100644

--- a/base/process/process_util_unittest.cc

+++ b/base/process/process_util_unittest.cc

@@ -234,9 +234,7 @@ MULTIPROCESS_TEST_MAIN(CrashingChildProcess) {

// This test intentionally crashes, so we don't need to run it under

// AddressSanitizer.

-// TODO(jschuh): crbug.com/175753 Fix this in Win64 bots.

-#if defined(ADDRESS_SANITIZER) || \

- (defined(OS_WIN) && defined(ARCH_CPU_X86_64)) || defined(SYZYASAN)

+#if defined(ADDRESS_SANITIZER) || defined(SYZYASAN)

#define MAYBE_GetTerminationStatusCrash DISABLED_GetTerminationStatusCrash

#else

#define MAYBE_GetTerminationStatusCrash GetTerminationStatusCrash

« no previous file with comments | « no previous file | no next file » | no next file with comments »