Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 2358613002: Fix possible divide by zero in vulkan granularity adjustments (Closed)

Created:
4 years, 3 months ago by egdaniel
Modified:
4 years, 3 months ago
Reviewers:
mtklein, ethannicholas
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix possible divide by zero in vulkan granularity adjustments This should fix the divide by zero crash on the nexus player bots BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358613002 Committed: https://skia.googlesource.com/skia/+/d5797b3059a4037a6dce4c0a66693ba471b1588e

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -20 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 1 1 chunk +30 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
egdaniel
4 years, 3 months ago (2016-09-20 16:03:56 UTC) #3
ethannicholas
lgtm
4 years, 3 months ago (2016-09-20 19:10:02 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2355883002 Patch 1). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-20 19:24:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358613002/20001
4 years, 3 months ago (2016-09-20 19:27:16 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 19:57:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d5797b3059a4037a6dce4c0a66693ba471b1588e

Powered by Google App Engine
This is Rietveld 408576698