Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2358603002: Update link output rule. (Closed)

Created:
4 years, 3 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update link output rule. BUG=648615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/807f7aaa0a7986dd91089305dcc626d09f197553 Cr-Commit-Position: refs/heads/master@{#420428}

Patch Set 1 #

Patch Set 2 : m #

Patch Set 3 : Fix pressed #

Patch Set 4 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -38 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 3 9 chunks +22 lines, -36 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
David Tseng
4 years, 3 months ago (2016-09-20 15:52:17 UTC) #4
dmazzoni
lgtm
4 years, 3 months ago (2016-09-21 18:48:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358603002/40001
4 years, 3 months ago (2016-09-21 22:16:59 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/239587)
4 years, 3 months ago (2016-09-21 23:08:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358603002/60001
4 years, 2 months ago (2016-09-22 18:27:53 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-22 19:38:43 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 19:43:25 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/807f7aaa0a7986dd91089305dcc626d09f197553
Cr-Commit-Position: refs/heads/master@{#420428}

Powered by Google App Engine
This is Rietveld 408576698