Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 2358593002: Flush contexts after LayerTreeHostImpl cleanup (Closed)

Created:
4 years, 3 months ago by ericrk
Modified:
4 years, 3 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flush contexts after LayerTreeHostImpl cleanup Currently, we do not flush our GL contexts after cleaning up LayerTreeHostImpl (LTHI) resources. This delays the time it takes for these deletes to reach the GPU process, and can allow driver caches to grow unnecessarily. This CL does a ShallowFlushCHROMIUM after freeing LTHI resources, which reduces cache growth on some platforms (observed on N9). R=vmpstr BUG=643251 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/d3bd7f0bacd5e2141ddb9f08335a9157da367b14 Cr-Commit-Position: refs/heads/master@{#419874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ericrk
Working around bad driver caching :/ - we used to (inadvertently) have the behavior before ...
4 years, 3 months ago (2016-09-20 15:39:14 UTC) #4
vmpstr
lgtm
4 years, 3 months ago (2016-09-20 21:00:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358593002/1
4 years, 3 months ago (2016-09-20 22:24:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 22:29:18 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 22:31:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3bd7f0bacd5e2141ddb9f08335a9157da367b14
Cr-Commit-Position: refs/heads/master@{#419874}

Powered by Google App Engine
This is Rietveld 408576698