Site Settings Desktop: Fix crash when deleting storage for a site.

chrome/browser/resources/settings/site_settings/site_details.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'site-details' show the details (permissions and usage) for a given origin
  * under Site Settings.
  */
 Polymer({
@@ skipping 57 matching lines @@
       // Using originForDisplay avoids the [*.] prefix that some exceptions use.
       var url = new URL(this.ensureUrlHasScheme(this.site.originForDisplay));
       this.$.usageApi.fetchUsageTotal(url.hostname);
     }
   },
 
   /**
    * Clears all data stored for the current origin.
    */
   onClearStorage_: function() {
-    this.$.usageApi.clearUsage(this.site.origin, this.storageType_);
+    this.$.usageApi.clearUsage(
+        this.toUrl(this.site.origin).href, this.storageType_);

[Finnur, 2016/09/20 11:37:27]

I found while testing this, that if patterns are entered we need to convert them
to url for the deletion to work.

   },
 
   /**
    * Called when usage has been deleted for an origin.
    */
   onUsageDeleted: function(event) {
-    if (event.detail.origin == this.site.origin) {
+    if (event.detail.origin == this.toUrl(this.site.origin).href) {

[Finnur, 2016/09/20 11:37:27]

And when the delete-complete event comes in, we need to make sure we don't
compare the origin against a pattern -- otherwise we ignore the event.

       this.storedData_ = '';
       this.navigateBackIfNoData_();
     }
   },
 
   /**
    * Resets all permissions and clears all data stored for the current origin.
    */
   onClearAndReset_: function() {
     Array.prototype.forEach.call(
@@ skipping 16 matching lines @@
 
   /**
    * Returns true if one or more permission is showing.
    */
   permissionShowing_: function() {
     return Array.prototype.some.call(
         this.root.querySelectorAll('site-details-permission'),
         function(element) { return element.offsetHeight > 0; });
   },
 });