Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/crankshaft/x87/lithium-codegen-x87.cc

Issue 2358533002: [crankshaft] Remove HStoreNamedGeneric and use HCallWithDescriptor instead to call StoreIC. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x64/lithium-x64.cc ('k') | src/crankshaft/x87/lithium-x87.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/crankshaft/x87/lithium-codegen-x87.h" 7 #include "src/crankshaft/x87/lithium-codegen-x87.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 3953 matching lines...) Expand 10 before | Expand all | Expand 10 after
3964 Register temp = access.IsInobject() ? ToRegister(instr->temp()) : object; 3964 Register temp = access.IsInobject() ? ToRegister(instr->temp()) : object;
3965 // Update the write barrier for the object for in-object properties. 3965 // Update the write barrier for the object for in-object properties.
3966 __ RecordWriteField(write_register, offset, value, temp, kSaveFPRegs, 3966 __ RecordWriteField(write_register, offset, value, temp, kSaveFPRegs,
3967 EMIT_REMEMBERED_SET, 3967 EMIT_REMEMBERED_SET,
3968 instr->hydrogen()->SmiCheckForWriteBarrier(), 3968 instr->hydrogen()->SmiCheckForWriteBarrier(),
3969 instr->hydrogen()->PointersToHereCheckForValue()); 3969 instr->hydrogen()->PointersToHereCheckForValue());
3970 } 3970 }
3971 } 3971 }
3972 3972
3973 3973
3974 void LCodeGen::DoStoreNamedGeneric(LStoreNamedGeneric* instr) {
3975 DCHECK(ToRegister(instr->context()).is(esi));
3976 DCHECK(ToRegister(instr->object()).is(StoreDescriptor::ReceiverRegister()));
3977 DCHECK(ToRegister(instr->value()).is(StoreDescriptor::ValueRegister()));
3978
3979 EmitVectorStoreICRegisters<LStoreNamedGeneric>(instr);
3980
3981 __ mov(StoreDescriptor::NameRegister(), instr->name());
3982 Handle<Code> ic =
3983 CodeFactory::StoreICInOptimizedCode(isolate(), instr->language_mode())
3984 .code();
3985 CallCode(ic, RelocInfo::CODE_TARGET, instr);
3986 }
3987
3988
3989 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) { 3974 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {
3990 Condition cc = instr->hydrogen()->allow_equality() ? above : above_equal; 3975 Condition cc = instr->hydrogen()->allow_equality() ? above : above_equal;
3991 if (instr->index()->IsConstantOperand()) { 3976 if (instr->index()->IsConstantOperand()) {
3992 __ cmp(ToOperand(instr->length()), 3977 __ cmp(ToOperand(instr->length()),
3993 ToImmediate(LConstantOperand::cast(instr->index()), 3978 ToImmediate(LConstantOperand::cast(instr->index()),
3994 instr->hydrogen()->length()->representation())); 3979 instr->hydrogen()->length()->representation()));
3995 cc = CommuteCondition(cc); 3980 cc = CommuteCondition(cc);
3996 } else if (instr->length()->IsConstantOperand()) { 3981 } else if (instr->length()->IsConstantOperand()) {
3997 __ cmp(ToOperand(instr->index()), 3982 __ cmp(ToOperand(instr->index()),
3998 ToImmediate(LConstantOperand::cast(instr->length()), 3983 ToImmediate(LConstantOperand::cast(instr->length()),
(...skipping 1769 matching lines...) Expand 10 before | Expand all | Expand 10 after
5768 __ bind(deferred->exit()); 5753 __ bind(deferred->exit());
5769 __ bind(&done); 5754 __ bind(&done);
5770 } 5755 }
5771 5756
5772 #undef __ 5757 #undef __
5773 5758
5774 } // namespace internal 5759 } // namespace internal
5775 } // namespace v8 5760 } // namespace v8
5776 5761
5777 #endif // V8_TARGET_ARCH_X87 5762 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/crankshaft/x64/lithium-x64.cc ('k') | src/crankshaft/x87/lithium-x87.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698