Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2358533002: [crankshaft] Remove HStoreNamedGeneric and use HCallWithDescriptor instead to call StoreIC. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/s390/lithium-s390.cc ('k') | src/crankshaft/x64/lithium-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/crankshaft/x64/lithium-codegen-x64.h" 7 #include "src/crankshaft/x64/lithium-codegen-x64.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 3879 matching lines...) Expand 10 before | Expand all | Expand 10 after
3890 value, 3890 value,
3891 temp, 3891 temp,
3892 kSaveFPRegs, 3892 kSaveFPRegs,
3893 EMIT_REMEMBERED_SET, 3893 EMIT_REMEMBERED_SET,
3894 hinstr->SmiCheckForWriteBarrier(), 3894 hinstr->SmiCheckForWriteBarrier(),
3895 hinstr->PointersToHereCheckForValue()); 3895 hinstr->PointersToHereCheckForValue());
3896 } 3896 }
3897 } 3897 }
3898 3898
3899 3899
3900 void LCodeGen::DoStoreNamedGeneric(LStoreNamedGeneric* instr) {
3901 DCHECK(ToRegister(instr->context()).is(rsi));
3902 DCHECK(ToRegister(instr->object()).is(StoreDescriptor::ReceiverRegister()));
3903 DCHECK(ToRegister(instr->value()).is(StoreDescriptor::ValueRegister()));
3904
3905 EmitVectorStoreICRegisters<LStoreNamedGeneric>(instr);
3906
3907 __ Move(StoreDescriptor::NameRegister(), instr->hydrogen()->name());
3908 Handle<Code> ic =
3909 CodeFactory::StoreICInOptimizedCode(isolate(), instr->language_mode())
3910 .code();
3911 CallCode(ic, RelocInfo::CODE_TARGET, instr);
3912 }
3913
3914
3915 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) { 3900 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {
3916 Representation representation = instr->hydrogen()->length()->representation(); 3901 Representation representation = instr->hydrogen()->length()->representation();
3917 DCHECK(representation.Equals(instr->hydrogen()->index()->representation())); 3902 DCHECK(representation.Equals(instr->hydrogen()->index()->representation()));
3918 DCHECK(representation.IsSmiOrInteger32()); 3903 DCHECK(representation.IsSmiOrInteger32());
3919 3904
3920 Condition cc = instr->hydrogen()->allow_equality() ? below : below_equal; 3905 Condition cc = instr->hydrogen()->allow_equality() ? below : below_equal;
3921 if (instr->length()->IsConstantOperand()) { 3906 if (instr->length()->IsConstantOperand()) {
3922 int32_t length = ToInteger32(LConstantOperand::cast(instr->length())); 3907 int32_t length = ToInteger32(LConstantOperand::cast(instr->length()));
3923 Register index = ToRegister(instr->index()); 3908 Register index = ToRegister(instr->index());
3924 if (representation.IsSmi()) { 3909 if (representation.IsSmi()) {
(...skipping 1639 matching lines...) Expand 10 before | Expand all | Expand 10 after
5564 __ bind(deferred->exit()); 5549 __ bind(deferred->exit());
5565 __ bind(&done); 5550 __ bind(&done);
5566 } 5551 }
5567 5552
5568 #undef __ 5553 #undef __
5569 5554
5570 } // namespace internal 5555 } // namespace internal
5571 } // namespace v8 5556 } // namespace v8
5572 5557
5573 #endif // V8_TARGET_ARCH_X64 5558 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/crankshaft/s390/lithium-s390.cc ('k') | src/crankshaft/x64/lithium-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698