Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: src/crankshaft/s390/lithium-s390.cc

Issue 2358533002: [crankshaft] Remove HStoreNamedGeneric and use HCallWithDescriptor instead to call StoreIC. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/s390/lithium-s390.h ('k') | src/crankshaft/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/s390/lithium-s390.h" 5 #include "src/crankshaft/s390/lithium-s390.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/crankshaft/hydrogen-osr.h" 9 #include "src/crankshaft/hydrogen-osr.h"
10 #include "src/crankshaft/lithium-inl.h" 10 #include "src/crankshaft/lithium-inl.h"
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 } 280 }
281 281
282 void LStoreNamedField::PrintDataTo(StringStream* stream) { 282 void LStoreNamedField::PrintDataTo(StringStream* stream) {
283 object()->PrintTo(stream); 283 object()->PrintTo(stream);
284 std::ostringstream os; 284 std::ostringstream os;
285 os << hydrogen()->access() << " <- "; 285 os << hydrogen()->access() << " <- ";
286 stream->Add(os.str().c_str()); 286 stream->Add(os.str().c_str());
287 value()->PrintTo(stream); 287 value()->PrintTo(stream);
288 } 288 }
289 289
290 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) {
291 object()->PrintTo(stream);
292 stream->Add(".");
293 stream->Add(String::cast(*name())->ToCString().get());
294 stream->Add(" <- ");
295 value()->PrintTo(stream);
296 }
297
298 void LLoadKeyed::PrintDataTo(StringStream* stream) { 290 void LLoadKeyed::PrintDataTo(StringStream* stream) {
299 elements()->PrintTo(stream); 291 elements()->PrintTo(stream);
300 stream->Add("["); 292 stream->Add("[");
301 key()->PrintTo(stream); 293 key()->PrintTo(stream);
302 if (hydrogen()->IsDehoisted()) { 294 if (hydrogen()->IsDehoisted()) {
303 stream->Add(" + %d]", base_offset()); 295 stream->Add(" + %d]", base_offset());
304 } else { 296 } else {
305 stream->Add("]"); 297 stream->Add("]");
306 } 298 }
307 } 299 }
(...skipping 1743 matching lines...) Expand 10 before | Expand all | Expand 10 after
2051 } else { 2043 } else {
2052 val = UseRegister(instr->value()); 2044 val = UseRegister(instr->value());
2053 } 2045 }
2054 2046
2055 // We need a temporary register for write barrier of the map field. 2047 // We need a temporary register for write barrier of the map field.
2056 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL; 2048 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL;
2057 2049
2058 return new (zone()) LStoreNamedField(obj, val, temp); 2050 return new (zone()) LStoreNamedField(obj, val, temp);
2059 } 2051 }
2060 2052
2061 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
2062 LOperand* context = UseFixed(instr->context(), cp);
2063 LOperand* obj =
2064 UseFixed(instr->object(), StoreDescriptor::ReceiverRegister());
2065 LOperand* val = UseFixed(instr->value(), StoreDescriptor::ValueRegister());
2066 LOperand* slot = FixedTemp(StoreWithVectorDescriptor::SlotRegister());
2067 LOperand* vector = FixedTemp(StoreWithVectorDescriptor::VectorRegister());
2068 LStoreNamedGeneric* result =
2069 new (zone()) LStoreNamedGeneric(context, obj, val, slot, vector);
2070 return MarkAsCall(result, instr);
2071 }
2072
2073 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) { 2053 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) {
2074 LOperand* context = UseFixed(instr->context(), cp); 2054 LOperand* context = UseFixed(instr->context(), cp);
2075 LOperand* left = UseFixed(instr->left(), r3); 2055 LOperand* left = UseFixed(instr->left(), r3);
2076 LOperand* right = UseFixed(instr->right(), r2); 2056 LOperand* right = UseFixed(instr->right(), r2);
2077 return MarkAsCall( 2057 return MarkAsCall(
2078 DefineFixed(new (zone()) LStringAdd(context, left, right), r2), instr); 2058 DefineFixed(new (zone()) LStringAdd(context, left, right), r2), instr);
2079 } 2059 }
2080 2060
2081 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) { 2061 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) {
2082 LOperand* string = UseTempRegister(instr->string()); 2062 LOperand* string = UseTempRegister(instr->string());
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
2258 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2238 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2259 LOperand* object = UseRegister(instr->object()); 2239 LOperand* object = UseRegister(instr->object());
2260 LOperand* index = UseTempRegister(instr->index()); 2240 LOperand* index = UseTempRegister(instr->index());
2261 LLoadFieldByIndex* load = new (zone()) LLoadFieldByIndex(object, index); 2241 LLoadFieldByIndex* load = new (zone()) LLoadFieldByIndex(object, index);
2262 LInstruction* result = DefineSameAsFirst(load); 2242 LInstruction* result = DefineSameAsFirst(load);
2263 return AssignPointerMap(result); 2243 return AssignPointerMap(result);
2264 } 2244 }
2265 2245
2266 } // namespace internal 2246 } // namespace internal
2267 } // namespace v8 2247 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/s390/lithium-s390.h ('k') | src/crankshaft/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698