Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/crankshaft/s390/lithium-codegen-s390.cc

Issue 2358533002: [crankshaft] Remove HStoreNamedGeneric and use HCallWithDescriptor instead to call StoreIC. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/ppc/lithium-ppc.cc ('k') | src/crankshaft/s390/lithium-s390.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // 2 //
3 // Use of this source code is governed by a BSD-style license that can be 3 // Use of this source code is governed by a BSD-style license that can be
4 // found in the LICENSE file. 4 // found in the LICENSE file.
5 5
6 #include "src/crankshaft/s390/lithium-codegen-s390.h" 6 #include "src/crankshaft/s390/lithium-codegen-s390.h"
7 7
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 3960 matching lines...) Expand 10 before | Expand all | Expand 10 after
3971 #endif 3971 #endif
3972 3972
3973 if (hinstr->NeedsWriteBarrier()) { 3973 if (hinstr->NeedsWriteBarrier()) {
3974 __ RecordWriteField(record_dest, offset, record_value, record_scratch, 3974 __ RecordWriteField(record_dest, offset, record_value, record_scratch,
3975 GetLinkRegisterState(), kSaveFPRegs, 3975 GetLinkRegisterState(), kSaveFPRegs,
3976 EMIT_REMEMBERED_SET, hinstr->SmiCheckForWriteBarrier(), 3976 EMIT_REMEMBERED_SET, hinstr->SmiCheckForWriteBarrier(),
3977 hinstr->PointersToHereCheckForValue()); 3977 hinstr->PointersToHereCheckForValue());
3978 } 3978 }
3979 } 3979 }
3980 3980
3981 void LCodeGen::DoStoreNamedGeneric(LStoreNamedGeneric* instr) {
3982 DCHECK(ToRegister(instr->context()).is(cp));
3983 DCHECK(ToRegister(instr->object()).is(StoreDescriptor::ReceiverRegister()));
3984 DCHECK(ToRegister(instr->value()).is(StoreDescriptor::ValueRegister()));
3985
3986 EmitVectorStoreICRegisters<LStoreNamedGeneric>(instr);
3987
3988 __ mov(StoreDescriptor::NameRegister(), Operand(instr->name()));
3989 Handle<Code> ic =
3990 CodeFactory::StoreICInOptimizedCode(isolate(), instr->language_mode())
3991 .code();
3992 CallCode(ic, RelocInfo::CODE_TARGET, instr);
3993 }
3994
3995 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) { 3981 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {
3996 Representation representation = instr->hydrogen()->length()->representation(); 3982 Representation representation = instr->hydrogen()->length()->representation();
3997 DCHECK(representation.Equals(instr->hydrogen()->index()->representation())); 3983 DCHECK(representation.Equals(instr->hydrogen()->index()->representation()));
3998 DCHECK(representation.IsSmiOrInteger32()); 3984 DCHECK(representation.IsSmiOrInteger32());
3999 3985
4000 Condition cc = instr->hydrogen()->allow_equality() ? lt : le; 3986 Condition cc = instr->hydrogen()->allow_equality() ? lt : le;
4001 if (instr->length()->IsConstantOperand()) { 3987 if (instr->length()->IsConstantOperand()) {
4002 int32_t length = ToInteger32(LConstantOperand::cast(instr->length())); 3988 int32_t length = ToInteger32(LConstantOperand::cast(instr->length()));
4003 Register index = ToRegister(instr->index()); 3989 Register index = ToRegister(instr->index());
4004 if (representation.IsSmi()) { 3990 if (representation.IsSmi()) {
(...skipping 1660 matching lines...) Expand 10 before | Expand all | Expand 10 after
5665 __ LoadP(result, 5651 __ LoadP(result,
5666 FieldMemOperand(scratch, FixedArray::kHeaderSize - kPointerSize)); 5652 FieldMemOperand(scratch, FixedArray::kHeaderSize - kPointerSize));
5667 __ bind(deferred->exit()); 5653 __ bind(deferred->exit());
5668 __ bind(&done); 5654 __ bind(&done);
5669 } 5655 }
5670 5656
5671 #undef __ 5657 #undef __
5672 5658
5673 } // namespace internal 5659 } // namespace internal
5674 } // namespace v8 5660 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/ppc/lithium-ppc.cc ('k') | src/crankshaft/s390/lithium-s390.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698