Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Side by Side Diff: src/crankshaft/ppc/lithium-ppc.cc

Issue 2358533002: [crankshaft] Remove HStoreNamedGeneric and use HCallWithDescriptor instead to call StoreIC. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/ppc/lithium-ppc.h ('k') | src/crankshaft/s390/lithium-codegen-s390.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/ppc/lithium-ppc.h" 5 #include "src/crankshaft/ppc/lithium-ppc.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/crankshaft/hydrogen-osr.h" 9 #include "src/crankshaft/hydrogen-osr.h"
10 #include "src/crankshaft/lithium-inl.h" 10 #include "src/crankshaft/lithium-inl.h"
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 310
311 void LStoreNamedField::PrintDataTo(StringStream* stream) { 311 void LStoreNamedField::PrintDataTo(StringStream* stream) {
312 object()->PrintTo(stream); 312 object()->PrintTo(stream);
313 std::ostringstream os; 313 std::ostringstream os;
314 os << hydrogen()->access() << " <- "; 314 os << hydrogen()->access() << " <- ";
315 stream->Add(os.str().c_str()); 315 stream->Add(os.str().c_str());
316 value()->PrintTo(stream); 316 value()->PrintTo(stream);
317 } 317 }
318 318
319 319
320 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) {
321 object()->PrintTo(stream);
322 stream->Add(".");
323 stream->Add(String::cast(*name())->ToCString().get());
324 stream->Add(" <- ");
325 value()->PrintTo(stream);
326 }
327
328
329 void LLoadKeyed::PrintDataTo(StringStream* stream) { 320 void LLoadKeyed::PrintDataTo(StringStream* stream) {
330 elements()->PrintTo(stream); 321 elements()->PrintTo(stream);
331 stream->Add("["); 322 stream->Add("[");
332 key()->PrintTo(stream); 323 key()->PrintTo(stream);
333 if (hydrogen()->IsDehoisted()) { 324 if (hydrogen()->IsDehoisted()) {
334 stream->Add(" + %d]", base_offset()); 325 stream->Add(" + %d]", base_offset());
335 } else { 326 } else {
336 stream->Add("]"); 327 stream->Add("]");
337 } 328 }
338 } 329 }
(...skipping 1899 matching lines...) Expand 10 before | Expand all | Expand 10 after
2238 val = UseRegister(instr->value()); 2229 val = UseRegister(instr->value());
2239 } 2230 }
2240 2231
2241 // We need a temporary register for write barrier of the map field. 2232 // We need a temporary register for write barrier of the map field.
2242 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL; 2233 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL;
2243 2234
2244 return new (zone()) LStoreNamedField(obj, val, temp); 2235 return new (zone()) LStoreNamedField(obj, val, temp);
2245 } 2236 }
2246 2237
2247 2238
2248 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
2249 LOperand* context = UseFixed(instr->context(), cp);
2250 LOperand* obj =
2251 UseFixed(instr->object(), StoreDescriptor::ReceiverRegister());
2252 LOperand* val = UseFixed(instr->value(), StoreDescriptor::ValueRegister());
2253 LOperand* slot = FixedTemp(StoreWithVectorDescriptor::SlotRegister());
2254 LOperand* vector = FixedTemp(StoreWithVectorDescriptor::VectorRegister());
2255 LStoreNamedGeneric* result =
2256 new (zone()) LStoreNamedGeneric(context, obj, val, slot, vector);
2257 return MarkAsCall(result, instr);
2258 }
2259
2260
2261 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) { 2239 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) {
2262 LOperand* context = UseFixed(instr->context(), cp); 2240 LOperand* context = UseFixed(instr->context(), cp);
2263 LOperand* left = UseFixed(instr->left(), r4); 2241 LOperand* left = UseFixed(instr->left(), r4);
2264 LOperand* right = UseFixed(instr->right(), r3); 2242 LOperand* right = UseFixed(instr->right(), r3);
2265 return MarkAsCall( 2243 return MarkAsCall(
2266 DefineFixed(new (zone()) LStringAdd(context, left, right), r3), instr); 2244 DefineFixed(new (zone()) LStringAdd(context, left, right), r3), instr);
2267 } 2245 }
2268 2246
2269 2247
2270 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) { 2248 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) {
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
2465 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2443 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2466 LOperand* object = UseRegister(instr->object()); 2444 LOperand* object = UseRegister(instr->object());
2467 LOperand* index = UseTempRegister(instr->index()); 2445 LOperand* index = UseTempRegister(instr->index());
2468 LLoadFieldByIndex* load = new (zone()) LLoadFieldByIndex(object, index); 2446 LLoadFieldByIndex* load = new (zone()) LLoadFieldByIndex(object, index);
2469 LInstruction* result = DefineSameAsFirst(load); 2447 LInstruction* result = DefineSameAsFirst(load);
2470 return AssignPointerMap(result); 2448 return AssignPointerMap(result);
2471 } 2449 }
2472 2450
2473 } // namespace internal 2451 } // namespace internal
2474 } // namespace v8 2452 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/ppc/lithium-ppc.h ('k') | src/crankshaft/s390/lithium-codegen-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698