Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: src/crankshaft/ppc/lithium-codegen-ppc.cc

Issue 2358533002: [crankshaft] Remove HStoreNamedGeneric and use HCallWithDescriptor instead to call StoreIC. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/mips64/lithium-mips64.cc ('k') | src/crankshaft/ppc/lithium-ppc.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/ppc/lithium-codegen-ppc.h" 5 #include "src/crankshaft/ppc/lithium-codegen-ppc.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/crankshaft/hydrogen-osr.h" 10 #include "src/crankshaft/hydrogen-osr.h"
(...skipping 4061 matching lines...) Expand 10 before | Expand all | Expand 10 after
4072 4072
4073 if (hinstr->NeedsWriteBarrier()) { 4073 if (hinstr->NeedsWriteBarrier()) {
4074 __ RecordWriteField(record_dest, offset, record_value, record_scratch, 4074 __ RecordWriteField(record_dest, offset, record_value, record_scratch,
4075 GetLinkRegisterState(), kSaveFPRegs, 4075 GetLinkRegisterState(), kSaveFPRegs,
4076 EMIT_REMEMBERED_SET, hinstr->SmiCheckForWriteBarrier(), 4076 EMIT_REMEMBERED_SET, hinstr->SmiCheckForWriteBarrier(),
4077 hinstr->PointersToHereCheckForValue()); 4077 hinstr->PointersToHereCheckForValue());
4078 } 4078 }
4079 } 4079 }
4080 4080
4081 4081
4082 void LCodeGen::DoStoreNamedGeneric(LStoreNamedGeneric* instr) {
4083 DCHECK(ToRegister(instr->context()).is(cp));
4084 DCHECK(ToRegister(instr->object()).is(StoreDescriptor::ReceiverRegister()));
4085 DCHECK(ToRegister(instr->value()).is(StoreDescriptor::ValueRegister()));
4086
4087 EmitVectorStoreICRegisters<LStoreNamedGeneric>(instr);
4088
4089 __ mov(StoreDescriptor::NameRegister(), Operand(instr->name()));
4090 Handle<Code> ic =
4091 CodeFactory::StoreICInOptimizedCode(isolate(), instr->language_mode())
4092 .code();
4093 CallCode(ic, RelocInfo::CODE_TARGET, instr);
4094 }
4095
4096
4097 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) { 4082 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {
4098 Representation representation = instr->hydrogen()->length()->representation(); 4083 Representation representation = instr->hydrogen()->length()->representation();
4099 DCHECK(representation.Equals(instr->hydrogen()->index()->representation())); 4084 DCHECK(representation.Equals(instr->hydrogen()->index()->representation()));
4100 DCHECK(representation.IsSmiOrInteger32()); 4085 DCHECK(representation.IsSmiOrInteger32());
4101 4086
4102 Condition cc = instr->hydrogen()->allow_equality() ? lt : le; 4087 Condition cc = instr->hydrogen()->allow_equality() ? lt : le;
4103 if (instr->length()->IsConstantOperand()) { 4088 if (instr->length()->IsConstantOperand()) {
4104 int32_t length = ToInteger32(LConstantOperand::cast(instr->length())); 4089 int32_t length = ToInteger32(LConstantOperand::cast(instr->length()));
4105 Register index = ToRegister(instr->index()); 4090 Register index = ToRegister(instr->index());
4106 if (representation.IsSmi()) { 4091 if (representation.IsSmi()) {
(...skipping 1669 matching lines...) Expand 10 before | Expand all | Expand 10 after
5776 __ LoadP(result, 5761 __ LoadP(result,
5777 FieldMemOperand(scratch, FixedArray::kHeaderSize - kPointerSize)); 5762 FieldMemOperand(scratch, FixedArray::kHeaderSize - kPointerSize));
5778 __ bind(deferred->exit()); 5763 __ bind(deferred->exit());
5779 __ bind(&done); 5764 __ bind(&done);
5780 } 5765 }
5781 5766
5782 #undef __ 5767 #undef __
5783 5768
5784 } // namespace internal 5769 } // namespace internal
5785 } // namespace v8 5770 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/mips64/lithium-mips64.cc ('k') | src/crankshaft/ppc/lithium-ppc.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698